Implements a % cap on staking rewards from era inflation #1660

gpestana · 2023-09-21T09:22:28Z

This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. The remaining is minted directly into the RewardRemainder account, which is the treasury pot account in Polkadot and Kusama.

The staking pallet now has a percent storage item, MaxStakersRewards, which defines the max percentage of the era inflation that should be allocated to staking rewards. The remaining era inflation (i.e. remaining = max_era_payout - staking_payout.min(staking_payout * MaxStakersRewards)) is minted directly into the treasury.

The MaxStakersRewards can be set by a privileged origin through the set_staking_configs extrinsic.

To finish

run benchmarks for westend-runtime

Replaces #1483
Closes #403

gpestana · 2023-09-22T10:59:51Z

bot bench polkadot-pallet --pallet=pallet_staking --runtime polkadot

command-bot · 2023-09-22T10:59:56Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=polkadot --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-6299fd2d-fa31-4702-9017-568fa5162db5 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-22T11:37:40Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=polkadot --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934/artifacts/download.

gpestana · 2023-09-22T12:18:23Z

bot bench substrate-pallet --pallet=pallet_staking

command-bot · 2023-09-22T12:18:28Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking was queued.

Comment bot cancel 6-b22a5e88-1858-41be-8925-d7eb4628e672 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-22T12:18:40Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

polkadot/runtime/common/src/impls.rs

substrate/frame/staking/src/lib.rs

substrate/frame/staking/src/mock.rs

Ank4n

A small nit but otherwise looks good.

polkadot/runtime/common/src/impls.rs

substrate/frame/staking/src/mock.rs

substrate/frame/staking/src/pallet/mod.rs

polkadot/runtime/kusama/src/weights/pallet_staking.rs

polkadot/runtime/polkadot/src/weights/pallet_staking.rs

polkadot/runtime/westend/src/weights/pallet_staking.rs

…ining

gpestana · 2023-09-23T13:41:08Z

bot bench substrate-pallet --pallet=pallet_staking

command-bot · 2023-09-23T13:41:15Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3779467 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-d6dfa0ed-f1ee-4795-8a98-728b4882ee01 to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

gpestana · 2024-01-28T12:56:41Z

bot fmt

command-bot · 2024-01-28T12:56:46Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050625 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-01761a0a-8767-4774-890e-f36344c7ec51 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-28T12:58:21Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050625 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050625/artifacts/download.

gpestana · 2024-01-28T12:59:03Z

bot bench polkadot-pallet --pallet=pallet_staking --runtime westend

command-bot · 2024-01-28T12:59:08Z

@gpestana "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050764) was cancelled in #1660 (comment)

gpestana · 2024-01-28T13:06:13Z

bot cancel 2-50f51a7a-9fe2-4098-a268-af52c5e61823

command-bot · 2024-01-28T13:06:18Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050764 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050764/artifacts/download.

gpestana · 2024-01-28T13:18:07Z

bot bench polkadot-pallet --pallet=pallet_staking --runtime westend

command-bot · 2024-01-28T13:18:11Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050797 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-3beb4642-622f-491f-939c-7feff4df7dbd to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

…=westend --target_dir=polkadot --pallet=pallet_staking

command-bot · 2024-01-28T14:26:01Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050797 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5050797/artifacts/download.

…#1660) This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. The remaining is minted directly into the [`RewardRemainder`](https://github.com/paritytech/polkadot-sdk/blob/d349b45d086199af7ad0195534e2b913ba9b6827/substrate/frame/staking/src/pallet/mod.rs#L160) account, which is the treasury pot account in Polkadot and Kusama. The staking pallet now has a percent storage item, `MaxStakersRewards`, which defines the max percentage of the era inflation that should be allocated to staking rewards. The remaining era inflation (i.e. `remaining = max_era_payout - staking_payout.min(staking_payout * MaxStakersRewards))` is minted directly into the treasury. The `MaxStakersRewards` can be set by a privileged origin through the `set_staking_configs` extrinsic. **To finish** - [x] run benchmarks for westend-runtime Replaces paritytech#1483 Closes paritytech#403 --------- Co-authored-by: command-bot <>

* remove dispatch_result field * fix benchmarks

* Use an actual Result inside MessageDispatchResult We need this in order to distinguish between Ok and Err * Revert #1660 * Fixes + simplifications * Implement review suggestions

Polkadot-Forum · 2024-06-20T12:52:18Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadots-economics-tools-to-shape-the-forseeable-future/8708/1

Polkadot-Forum · 2024-07-18T10:33:08Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/proposal-for-adjusting-polkadots-inflation-system-reducing-issuance-and-complexity/9157/1

Adds minimum treasury inflation per era

e88d2cd

gpestana requested review from a team September 21, 2023 09:22

gpestana self-assigned this Sep 21, 2023

gpestana marked this pull request as draft September 21, 2023 09:22

gpestana mentioned this pull request Sep 21, 2023

Implements partial inflation minting to treasury #1483

Closed

gpestana changed the title ~~Adds minimum treasury inflation per era~~ Implements minimum era inflation minting to treasury Sep 21, 2023

Adds set_min_treasury_fraction extrinsic; Improves tests

8a64bef

gpestana added T2-pallets This PR/Issue is related to a particular pallet. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Sep 22, 2023

gpestana marked this pull request as ready for review September 22, 2023 11:00

gpestana requested review from kianenigma and Ank4n September 22, 2023 11:00

gpestana changed the title ~~Implements minimum era inflation minting to treasury~~ Implements minimum era inflation minting as remainder Sep 22, 2023

Updates docs

810e9d8

liamaharon reviewed Sep 22, 2023

View reviewed changes

polkadot/runtime/common/src/impls.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/lib.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/mock.rs Outdated Show resolved Hide resolved

Ank4n approved these changes Sep 22, 2023

View reviewed changes

polkadot/runtime/common/src/impls.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/mock.rs Outdated Show resolved Hide resolved

substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved

juangirini reviewed Sep 22, 2023

View reviewed changes

polkadot/runtime/kusama/src/weights/pallet_staking.rs Outdated Show resolved Hide resolved

juangirini reviewed Sep 22, 2023

View reviewed changes

polkadot/runtime/polkadot/src/weights/pallet_staking.rs Outdated Show resolved Hide resolved

juangirini reviewed Sep 22, 2023

View reviewed changes

polkadot/runtime/westend/src/weights/pallet_staking.rs Outdated Show resolved Hide resolved

refactors so that the max_stakers_payout is used rather than min_rema…

02d5512

…ining

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

9ad6e10

…nto HEAD

fixes benchmarks

f9f4e94

command-bot added 2 commits January 28, 2024 13:20

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

4f589b3

…nto HEAD

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

73adb6c

…=westend --target_dir=polkadot --pallet=pallet_staking

gpestana enabled auto-merge February 14, 2024 17:19

Merge branch 'master' into gpestana/403-treasury_mint_remainder

72d5f3c

gpestana added this pull request to the merge queue Feb 15, 2024

Merged via the queue into master with commit fde4447 Feb 15, 2024
128 of 129 checks passed

gpestana deleted the gpestana/403-treasury_mint_remainder branch February 15, 2024 19:38

bkchr pushed a commit that referenced this pull request Apr 10, 2024

Remove dispatch_result field (#1660)

1688b49

* remove dispatch_result field * fix benchmarks

filippoweb3 mentioned this pull request Oct 3, 2024

Add new inflation info w3f/polkadot-wiki#6287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements a % cap on staking rewards from era inflation #1660

Implements a % cap on staking rewards from era inflation #1660

gpestana commented Sep 21, 2023 •

edited

Loading

gpestana commented Sep 22, 2023

command-bot bot commented Sep 22, 2023 •

edited

Loading

command-bot bot commented Sep 22, 2023

gpestana commented Sep 22, 2023

command-bot bot commented Sep 22, 2023 •

edited

Loading

command-bot bot commented Sep 22, 2023

Ank4n left a comment

gpestana commented Sep 23, 2023

command-bot bot commented Sep 23, 2023 •

edited

Loading

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 •

edited

Loading

command-bot bot commented Jan 28, 2024

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 •

edited

Loading

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 •

edited

Loading

command-bot bot commented Jan 28, 2024

Polkadot-Forum commented Jun 20, 2024

Polkadot-Forum commented Jul 18, 2024

Implements a % cap on staking rewards from era inflation #1660

Implements a % cap on staking rewards from era inflation #1660

Conversation

gpestana commented Sep 21, 2023 • edited Loading

gpestana commented Sep 22, 2023

command-bot bot commented Sep 22, 2023 • edited Loading

command-bot bot commented Sep 22, 2023

gpestana commented Sep 22, 2023

command-bot bot commented Sep 22, 2023 • edited Loading

command-bot bot commented Sep 22, 2023

Ank4n left a comment

Choose a reason for hiding this comment

gpestana commented Sep 23, 2023

command-bot bot commented Sep 23, 2023 • edited Loading

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 • edited Loading

command-bot bot commented Jan 28, 2024

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 • edited Loading

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024

gpestana commented Jan 28, 2024

command-bot bot commented Jan 28, 2024 • edited Loading

command-bot bot commented Jan 28, 2024

Polkadot-Forum commented Jun 20, 2024

Polkadot-Forum commented Jul 18, 2024

gpestana commented Sep 21, 2023 •

edited

Loading

command-bot bot commented Sep 22, 2023 •

edited

Loading

command-bot bot commented Sep 22, 2023 •

edited

Loading

command-bot bot commented Sep 23, 2023 •

edited

Loading

command-bot bot commented Jan 28, 2024 •

edited

Loading

command-bot bot commented Jan 28, 2024 •

edited

Loading

command-bot bot commented Jan 28, 2024 •

edited

Loading