Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet alliance / update to use fungible #1675

Closed
wants to merge 1 commit into from

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented Sep 22, 2023

This updates the alliance pallet to use the new fungible traits rather than the now deprecated Currency and ReserveCurrency traits ( paritytech/substrate#12951 ). Partial fix of #226.

Todo:

  • Add code (if needed) to handle migrations.
  • Update runtimes

@gilescope gilescope added the T2-pallets This PR/Issue is related to a particular pallet. label Sep 22, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769534

@gilescope
Copy link
Contributor Author

I don't think we want to have to switch the treasury over to fungibles yet so we might have to add an adaptor between the imbalance type mismatch.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can probably use Conasiderations instead.

@bkchr bkchr closed this Jul 17, 2024
@bkchr bkchr deleted the giles-upgrade-fungibles-alliance branch July 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants