Migrate lease deposits from reserves to named holds #1794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #226.
Useful for redoing this PR without needing to have an extra storage for keeping track of reserved amounts.
This PR will be followed by another PR that adds the new extrinsic
early_lease_refundfunctionally same as these changes.Migration note
Leasesstorage is unbounded but leases can only be assigned via auction and new auctions can only be created by root origin. The number of leases currently on Kusama and Polkadot is45and53respectively and hence safe to migrate all of them in one block (instead of a lazy migrate approach).You can use the following query to check the count of keys that we are iterating over in the migration:
console.log((await api.query.slots.leases.entries()).length);