Extend `Consideration` trait #1813

NachoPal · 2023-10-07T18:33:26Z

Draft exploring the idea of extending Consideration trait with new_from_exact(who: &AccountId, new: Balance)

It would be useful for migrations from Deposits to Consideration tickets where a fixed Footprint might not always return the expected deposited Balance.

Is it possible to do it in a different way? right now it creates a dependency on Currency, which I think is actually supposed to be removed in favor of Consideration.

liamaharon · 2023-10-07T21:02:51Z

Is it possible to do it in a different way? right now it creates a dependancy on Currency, which I think is actually supposed to be removed in favor of Consideration.

I don't see any dependency on Currency being introduced here?

This approach seems fine to me.

NachoPal · 2023-10-08T14:14:50Z

I don't see any dependency on Currency being introduced here?

The dependency is introduced when using BalanceOf<T>.

See #1569 (Edited, it wasn't linking to the right place)

liamaharon · 2023-10-10T10:09:16Z

The dev only needs to specify the Balance type, this type is not bound to Currency.

All implementations of Consideration already assume the existence of a Balance, so this feels fine to me.

NachoPal · 2023-10-10T12:41:34Z

bot fmt

command-bot · 2023-10-10T12:41:39Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3922343 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-565c5f0f-0872-4b29-ba37-b37dfcb211c9 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-10T12:42:22Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3922343 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3922343/artifacts/download.

franciscoaguirre · 2023-11-02T09:43:52Z

substrate/frame/support/src/traits/storage.rs

+	/// Create a ticket for a `new` balance attributable to `who`. This ticket *must* ultimately
+	/// be consumed through `update` or `drop` once the footprint changes or is removed.
+	/// This is useful when a new ticket needs to be created with a precise balance, instead of
+	/// deriving it from a footprint


The doc comment still mentions a footprint

kianenigma

High level, one of the main goals of Consideration is to abstract away the need for the existence of any "Balance/Currency" sub-system in a runtime, the fact that we need to add a Balance generic to the trait now seems like the wrong compromise to me.

I recall this was solving an important issue with migrations though, so I would not block it. Possibly it can be a temporary hack, in which case you can document the method as "it is temporary".

What alternatives we have?

juangirini · 2023-11-02T11:35:27Z

Which migrations would benefit from this?

NachoPal · 2023-11-02T13:49:10Z

Which migrations would benefit from this?

@juangirini Those were the Deposit might not have been constant over time (increased by a runtime upgrade).

During the migration, the new HoldConsideration will result in a fixed Balance (based on a fixed Footprint and a constant Convert function).

Let's say that during the migration, the new HoldConsideration is expected to have Balance = 10. What would happen when for a particular account the stored Deposit = 5? After Currency::unreserve(account, 5), when trying to create a new ticket to hold Balance = 10, it might fail (not enough balance). Currently, HoldConsideration::new() returns either Ok(()) or Err. What to do if it is not possible to hold the balance?

What alternatives we have?

@kianenigma The only alternative I see is to waive the deposit and not generate any ticket.

ggwpez · 2023-11-02T16:35:40Z

After discussing it I think it would be less invasive to create a type solely for migrating from Currency.
Something like HoldConsiderationFromLegacy or whatever that has this new_from_exact function (plus a trait for it).
That way we dont have to modify the normal production version of Hold / FreezeConsiderations.

gavofyork · 2023-11-02T16:44:14Z

substrate/frame/support/src/traits/storage.rs

@@ -208,11 +208,17 @@ where
 /// treated as one*. Don't type to duplicate it, and remember to drop it when you're done with
 /// it.
 #[must_use]
-pub trait Consideration<AccountId>: Member + FullCodec + TypeInfo + MaxEncodedLen {
+pub trait Consideration<AccountId, Balance>: Member + FullCodec + TypeInfo + MaxEncodedLen {


Considerations need not have anything to do with balances.

NachoPal · 2023-11-02T18:17:47Z

Closing it. I'll give it a try to this alternative: #1813

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

extend Consideration api

50c9895

".git/.scripts/commands/fmt/fmt.sh"

b289b1b

NachoPal added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 10, 2023

NachoPal marked this pull request as ready for review October 10, 2023 12:44

NachoPal requested review from a team, liamaharon and kianenigma October 10, 2023 12:44

liamaharon approved these changes Oct 10, 2023

View reviewed changes

NachoPal requested review from gpestana, Ank4n and ggwpez October 16, 2023 08:57

franciscoaguirre reviewed Nov 2, 2023

View reviewed changes

kianenigma reviewed Nov 2, 2023

View reviewed changes

gavofyork reviewed Nov 2, 2023

View reviewed changes

NachoPal closed this Nov 2, 2023

NachoPal mentioned this pull request Nov 10, 2023

Add ConsiderationFromLegacy traits #2274

Open

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

7b946da

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

bb13c18

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

3a20fd9

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

8fb3818

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

718da9d

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

28119ee

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

5c619e7

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

559445c

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

b61d2d7

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

dbbf313

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

cbce3cb

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

4bdcdcb

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

727024f

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

49ecd9e

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

Backport xcm bridging extensions to the bridge repo (paritytech#1813)

b7e785c

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

bkchr pushed a commit that referenced this pull request Apr 10, 2024

Backport xcm bridging extensions to the bridge repo (#1813)

a1c6502

* Backport xcm bridging extensions to the bridge repo * Fixes * Fixes

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend `Consideration` trait #1813

Extend `Consideration` trait #1813

NachoPal commented Oct 7, 2023 •

edited

Loading

liamaharon commented Oct 7, 2023 •

edited

Loading

NachoPal commented Oct 8, 2023 •

edited

Loading

liamaharon commented Oct 10, 2023 •

edited

Loading

NachoPal commented Oct 10, 2023

command-bot bot commented Oct 10, 2023 •

edited

Loading

command-bot bot commented Oct 10, 2023

franciscoaguirre Nov 2, 2023

kianenigma left a comment

juangirini commented Nov 2, 2023

NachoPal commented Nov 2, 2023 •

edited

Loading

ggwpez commented Nov 2, 2023 •

edited

Loading

gavofyork Nov 2, 2023

gavofyork Nov 2, 2023

NachoPal commented Nov 2, 2023

Extend Consideration trait #1813

Extend Consideration trait #1813

Conversation

NachoPal commented Oct 7, 2023 • edited Loading

liamaharon commented Oct 7, 2023 • edited Loading

NachoPal commented Oct 8, 2023 • edited Loading

liamaharon commented Oct 10, 2023 • edited Loading

NachoPal commented Oct 10, 2023

command-bot bot commented Oct 10, 2023 • edited Loading

command-bot bot commented Oct 10, 2023

franciscoaguirre Nov 2, 2023

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

juangirini commented Nov 2, 2023

NachoPal commented Nov 2, 2023 • edited Loading

ggwpez commented Nov 2, 2023 • edited Loading

gavofyork Nov 2, 2023

Choose a reason for hiding this comment

gavofyork Nov 2, 2023

Choose a reason for hiding this comment

NachoPal commented Nov 2, 2023

Extend `Consideration` trait #1813

Extend `Consideration` trait #1813

NachoPal commented Oct 7, 2023 •

edited

Loading

liamaharon commented Oct 7, 2023 •

edited

Loading

NachoPal commented Oct 8, 2023 •

edited

Loading

liamaharon commented Oct 10, 2023 •

edited

Loading

command-bot bot commented Oct 10, 2023 •

edited

Loading

NachoPal commented Nov 2, 2023 •

edited

Loading

ggwpez commented Nov 2, 2023 •

edited

Loading