Use defaultConfig for pallet_contracts #1817
Conversation
pgherveou
added
R0-silent
* functions to benchmark messages pallet with linked to parachain * unused imports * fmt
|
@pgherveou Are we good to proceed here? Any blockers? |
Kind of forgot about it, will bring it up to date :) |
|
just merge conflicts, will re-go through the different types to pick sensible defaults |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
cc @gupnik how does that look now? |
substrate/frame/contracts/mock-network/src/parachain/contracts_config.rs
Show resolved
Hide resolved
substrate/frame/contracts/src/lib.rs
Outdated
| pub trait Config: frame_system::Config { | ||
| /// The time implementation used to supply timestamps to contracts through `seal_now`. | ||
| #[pallet::no_default] |
There was a problem hiding this comment.
Not possible to provide a default here?
There was a problem hiding this comment.
Yeah you would most likely want to override it, if you do anything that use that type in your tests, but I can provide an implementation that is unimplented!
| type ChainExtension: chain_extension::ChainExtension<Self> + Default; | ||
|
|
||
| /// Cost schedule and limits. | ||
| #[pallet::constant] | ||
| #[pallet::no_default] |
There was a problem hiding this comment.
Tried with no_default_bounds?
There was a problem hiding this comment.
| @@ -326,6 +339,7 @@ pub mod pallet { | |||
| /// | |||
| /// This setting along with [`MaxCodeLen`](#associatedtype.MaxCodeLen) directly affects | |||
| /// memory usage of your runtime. | |||
| #[pallet::no_default] | |||
There was a problem hiding this comment.
same, the trait is generic over T
No description provided.