-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump ci image to rust 1.73.0 #1830
Conversation
16a5b68
to
3591975
Compare
bot update-ui -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.73.0-2023-05-23-v20231009 |
@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179 was started for your command Comment |
@altaua Command |
dd5e962
to
1ccbda5
Compare
bot fmt |
@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467 was started for your command Comment |
@altaua Command |
@@ -1423,7 +1423,6 @@ impl NetworkBehaviour for Notifications { | |||
let delay_id = self.next_delay_id; | |||
self.next_delay_id.0 += 1; | |||
let delay = futures_timer::Delay::new(ban_duration); | |||
let peer_id = peer_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder why these were here before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to be let peer_id = *peer_id;
until this commit, which just removed the *
and left the remaining no-op line around.
31657d3
to
f925f9d
Compare
f925f9d
to
916c6cd
Compare
023a9e8
to
8333105
Compare
Can you also check if its worth to update the Rust version that the |
yeah that's on the todo list too, nightly bumps are always a huge hassle though |
8333105
to
0f6eebc
Compare
* master: (33 commits) ci: set CI_IMAGE back to (now updated) .ci-unified (#1854) ci: bump ci image to rust 1.73.0 (#1830) Refactor Identity to benchmark v2 (#1838) PVF worker: bump landlock, update ABI docs (#1850) Xcm emulator nits (#1649) Fixes path issue in derive-impl (#1823) upgrade to macro_magic 0.4.3 (#1832) Use safe math when pruning statuses (#1835) remote-ext: fix state download stall on slow connections and reduce memory usage (#1295) Update testnet bootnode dns name (#1712) [FRAME] Warn on unchecked weight witness (#1818) [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726) Update bridges subtree (#1803) Check for parent of first ready block being on chain (#1812) Make CheckNonce refuse transactions signed by accounts with no providers (#1578) Fix Asset Hub collator crashing when starting from genesis (#1788) Mixnet integration (#1346) [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458) Treasury spends various asset kinds (#1333) chore: bump zombienter version (#1806) ...
Co-authored-by: command-bot <>
Co-authored-by: command-bot <>
No description provided.