Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci check for parity-publish and fix current check issues #1887

Merged
merged 37 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
67509c7
Publish needed crates
Morganamilo Oct 16, 2023
6a9e990
Rename node-cli to staging-node-cli
Morganamilo Oct 16, 2023
042a9f8
Rename parachain-info to staging-parachain-info
Morganamilo Oct 16, 2023
33e3ff0
Rename chain-spec-builder to staging-chain-spec-builder
Morganamilo Oct 16, 2023
6b49830
Rename more crates
Morganamilo Oct 16, 2023
ab65641
Add licenses
Morganamilo Oct 16, 2023
38edc69
Remove non existant readme
Morganamilo Oct 16, 2023
bdc3dfe
Add publish check
Morganamilo Oct 16, 2023
07b6880
Rename imports in tests
Morganamilo Oct 16, 2023
fe6031a
Build parity-publish in dev
Morganamilo Oct 16, 2023
f3ed67f
cargo fmt
Morganamilo Oct 16, 2023
34c2197
Use parity-publish from registry
Morganamilo Oct 17, 2023
c5ea8fc
Rebase fixup
Morganamilo Oct 25, 2023
03f9aef
Add cache
Morganamilo Oct 25, 2023
54ad02a
rebase fixup
Morganamilo Oct 25, 2023
cfc41a0
Fix CI
Morganamilo Oct 25, 2023
f702ac2
Update .github/workflows/check-publish.yml
Morganamilo Oct 25, 2023
2db440d
Update .github/workflows/check-publish.yml
Morganamilo Oct 25, 2023
83c3f51
Fix CI
Morganamilo Oct 25, 2023
349245a
Fix CI
Morganamilo Oct 25, 2023
0e0787a
Fix CI
Morganamilo Oct 25, 2023
b646858
Update .github/workflows/check-publish.yml
Morganamilo Oct 25, 2023
00aaa4c
Fix CI
Morganamilo Oct 25, 2023
030d21e
Fix CI
Morganamilo Oct 25, 2023
8afde0b
Fix CI
Morganamilo Oct 25, 2023
0e88169
Fix CI
Morganamilo Oct 25, 2023
c3f5501
Trigger CI
Morganamilo Oct 25, 2023
59fa737
Revert main `Cargo.lock` changes
bkchr Oct 25, 2023
a375014
Don't publish node
Morganamilo Oct 31, 2023
d8fd392
Don't publish executor
Morganamilo Oct 31, 2023
d627606
Don't publish node-primitives
Morganamilo Oct 31, 2023
33566e6
Add missing license
Morganamilo Oct 31, 2023
34758a3
Merge remote-tracking branch 'origin/master' into morganamilo/cicheck
Morganamilo Oct 31, 2023
0f3075c
Rename crates back
Morganamilo Oct 31, 2023
9de066a
Fix licenses
Morganamilo Oct 31, 2023
7014f06
Merge branch 'master' into morganamilo/cicheck
Morganamilo Oct 31, 2023
53c8540
Fix readme
Morganamilo Oct 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/check-publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Check publish

on:
push:
branches:
- master
pull_request:
types: [opened, synchronize, reopened, ready_for_review]

jobs:
check-publish:
strategy:
matrix:
sergejparity marked this conversation as resolved.
Show resolved Hide resolved
os: ["ubuntu-latest"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0

Morganamilo marked this conversation as resolved.
Show resolved Hide resolved
- name: Rust Cache
uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
Morganamilo marked this conversation as resolved.
Show resolved Hide resolved
with:
cache-on-failure: true

- name: install parity-publish
run: cargo install parity-publish --profile dev

- name: parity-publish check
run: parity-publish check --allow-unpublished
2 changes: 1 addition & 1 deletion .gitlab/pipeline/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ build-linux-substrate:
# see https://github.com/paritytech/ci_cd/issues/682#issuecomment-1340953589
- git checkout -B "$CI_COMMIT_REF_NAME" "$CI_COMMIT_SHA"
script:
- WASM_BUILD_NO_COLOR=1 time cargo build --locked --release -p node-cli
- WASM_BUILD_NO_COLOR=1 time cargo build --locked --release -p staging-node-cli
- mv $CARGO_TARGET_DIR/release/substrate-node ./artifacts/substrate/substrate
- echo -n "Substrate version = "
- if [ "${CI_COMMIT_TAG}" ]; then
Expand Down
4 changes: 2 additions & 2 deletions .gitlab/pipeline/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ quick-benchmarks:
WASM_BUILD_NO_COLOR: 1
WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings"
script:
- time cargo run --locked --release -p node-cli --bin substrate-node --features runtime-benchmarks -- benchmark pallet --execution wasm --wasm-execution compiled --chain dev --pallet "*" --extrinsic "*" --steps 2 --repeat 1
- time cargo run --locked --release -p staging-node-cli --bin substrate-node --features runtime-benchmarks -- benchmark pallet --execution wasm --wasm-execution compiled --chain dev --pallet "*" --extrinsic "*" --steps 2 --repeat 1

test-frame-examples-compile-to-wasm:
# into one job
Expand Down Expand Up @@ -396,7 +396,7 @@ test-linux-stable-int:
script:
- WASM_BUILD_NO_COLOR=1
RUST_LOG=sync=trace,consensus=trace,client=trace,state-db=trace,db=trace,forks=trace,state_db=trace,storage_cache=trace
time cargo test -p node-cli --release --locked -- --ignored
time cargo test -p staging-node-cli --release --locked -- --ignored

# more information about this job can be found here:
# https://github.com/paritytech/substrate/pull/6916
Expand Down
Loading
Loading