polkadot-parachain-primitives should not depend on frame-support.
#1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is jsut a re-export of the former, but it brings a lot of baggage to the dependency graph for projects that are not using frame.
ordian
approved these changes
Oct 16, 2023
|
bot fmt |
|
@ordian https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3977746 was started for your command Comment |
|
@ordian Command |
ordian
added
the
T8-polkadot
gupnik
approved these changes
Oct 18, 2023
bkchr
approved these changes
Oct 20, 2023
|
Just checking in here. Is there anything I can do to help get this merged? |
ordian
added a commit
that referenced
this pull request
Oct 26, 2023
* master: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)
ordian
added a commit
that referenced
this pull request
Oct 26, 2023
* tsv-disabling: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)
ordian
added a commit
that referenced
this pull request
Oct 26, 2023
* tsv-disabling: (36 commits) Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008) Refactor candidates test in paras_inherent (#2004) PVF: Add worker check during tests and benches (#1771) Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997) polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002) Make `IdentityInfo` generic in `pallet-identity` (#1661) Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900) `CheckWeight`: Add more logging (#1996) ...
s0me0ne-unkn0wn
pushed a commit
that referenced
this pull request
Oct 29, 2023
…#1897) This PR does not make any functional changes to the code. Rather, it restructures the dependency graph. Before this PR, the crate `polkadot-parachain-primitives` depended directly on the crate `frame-support`. This is wrong in principal because a parachain does not necessarily have anything to do with frame. This dependency was only for the `Weight` type which was just a re-export from `sp-weights` anyway. So this PR changes the dependency to be directly on the much lighter `sp-weights`. --------- Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com> Co-authored-by: command-bot <>
JoshOrndorff
added a commit
to Off-Narrative-Labs/polkadot-sdk
that referenced
this pull request
Nov 22, 2023
…paritytech#1897) This PR does not make any functional changes to the code. Rather, it restructures the dependency graph. Before this PR, the crate `polkadot-parachain-primitives` depended directly on the crate `frame-support`. This is wrong in principal because a parachain does not necessarily have anything to do with frame. This dependency was only for the `Weight` type which was just a re-export from `sp-weights` anyway. So this PR changes the dependency to be directly on the much lighter `sp-weights`. --------- Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com> Co-authored-by: command-bot <>
JoshOrndorff
pushed a commit
to Off-Narrative-Labs/Tuxedo
that referenced
this pull request
Nov 22, 2023
JoshOrndorff
added a commit
to Off-Narrative-Labs/Tuxedo
that referenced
this pull request
Nov 28, 2023
* copy in parachain template, and sort out cargo.toml
* Stub in collect collation info api
* Copy in key parts of pallet parachain system
* kick can down road on inherent scraping
* scribble idea about calling existing runtime apis from validate block
* change default paraid to 2000
* Install proper inherent data providers in collator client-side.
* Install parachain piece in the runtime
* Add zombienet config
* feature gate parachain aspects of runtime and restore working standalone node.
* Testing Validate block is tricky because the `validate_block` function is only built to wasm. I think it has to be that way because overwriting host functions... Maybe there is more to be explored here, but I found it not that rewarding of a direction. Feel free to explore more especially if we get desperate.
* Unit tests for parachain piece
* Proper hrmp watermark. Achieve working POC 🤵♂️🤱🍆🪂⛓️👶❗️
* Use TuxedoGenesisBlockBuilder in parachain service
* Use modified `ExportGenesisState` aka `ExportGenesisHead` command.
* Parachain docker image
* Switch branch to 1.3.0 fork
Pick paritytech/polkadot-sdk#1897 into our target branch
* Bring in dev service and enable it exactly when using --dev
---------
Co-authored-by: Matteo Muraca <56828990+muraca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not make any functional changes to the code. Rather, it restructures the dependency graph.
Before this PR, the crate
polkadot-parachain-primitivesdepended directly on the crateframe-support. This is wrong in principal because a parachain does not necessarily have anything to do with frame.This dependency was only for the
Weighttype which was just a re-export fromsp-weightsanyway. So this PR changes the dependency to be directly on the much lightersp-weights.