[DNM] Debug 1631 #1917
Closed
[DNM] Debug 1631 #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Recent optimization in `V1Lazy` caused syncing to stall if if a request was sent to a peer who didn't support the request-response protocol.
Addresses getting removed from Kademlia for completely innocuous reasons such as keep-alive timeouts are causing the node to have a lot of dial failures. The dial failures happen because when `ProtocolController` tries to connect to a node, and when the address is trying to be fetched from from `Discovery`, it returns an empty vector since `Kademlia` no longer holds any addresses for the peer.
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
|
A fix to the PRDOc issue is ready in #1947 |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:
Use Github semantic
linking
to address any open issues this PR relates to or closes.
Fixes # (issue number, if applicable)
Closes # (issue number, if applicable)
Checklist
Trequired)
You can remove the "Checklist" section once all have been checked. Thank you for your contribution!
✄ -----------------------------------------------------------------------------