-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds stake-tracker
pallet and integrates with the staking pallet
#1933
Closed
Closed
Changes from 141 commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
5803d69
Adds `stake-tracker` pallet and integrates with the staking pallet
gpestana c7ad6bf
Comments and other nit fixes
gpestana cb393b9
Removes the untracked stake
gpestana 84a3b71
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 46f5f2e
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana b9d3f64
Removes completely the untracked stake code
gpestana b42a160
Fixes to review comments
gpestana 086a183
more improvements
gpestana 7b89e06
fixes comments
gpestana ad1c49d
nits and more tests
gpestana 2c2256d
nits and more tests
gpestana e2babf5
Adds more tests
gpestana cab3568
Adds more testing
gpestana 0152b34
improves testing
gpestana ae98ed9
Change score typ of target list from voteweight to balance
gpestana ac4a7af
adds more rebagging and sorting tests to stake-tracker
gpestana c2d681d
More tests
gpestana 4e06d60
test fixing due to new target list ordering
gpestana bbc59a5
Adds more staking tests for the stake-tracker integration
gpestana 33a9357
more stake_tracker integration tests
gpestana 01793c5
fixes target score updates when kicking
gpestana fee0514
Addresses review comments; moves stake-tracker into staking crate
gpestana 30a9c47
Adds more defensives
gpestana 05c40db
ledger.kill will fail if preconditions have not been met
gpestana 77d7762
fixes remaining tests
gpestana f3e4185
Adds stake-tracker to westend runtime
gpestana bd2d7e2
nits to make CI happy
gpestana ed3cc48
Update substrate/frame/staking/src/mock.rs
gpestana dc141ad
Update substrate/frame/staking/stake-tracker/src/mock.rs
gpestana bbb5740
Update substrate/frame/staking/stake-tracker/src/lib.rs
gpestana 1d98e7d
Update substrate/frame/staking/stake-tracker/Cargo.toml
gpestana 964413c
Adds try-state checks to stake-tracker pallet; review nits
gpestana 25c97e1
Removes duplicate assert
gpestana f9c439c
Refactors staking and `stake-tracker` so that target and voter lists …
gpestana b09f8bc
Addresses review comments
gpestana 062868d
review comments
gpestana 992cff1
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 70ab8c3
".git/.scripts/commands/fmt/fmt.sh"
ee52b6f
Update documentation
gpestana a3b0b41
Wraps slash tests on TestExternalities
gpestana f1526e0
Removes ability to explicitly add moot nominations, as it fails with …
gpestana 2870db3
Keeps approvals even if the validator chills or stash is killed (if t…
gpestana 6713df3
Update docs; VoterList node is removed upon chilling.
gpestana 341e28e
Update substrate/frame/staking/stake-tracker/src/lib.rs
gpestana dba853b
review nits
gpestana b316f6f
Refactor `OnStakingUpdate` interface to be safer to use. (#2877)
gpestana 261456e
Fixes fast-unstake test setup
gpestana 27a85fc
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 088783e
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana bf1e043
simplifies do_add_validator
gpestana c0497b2
Adds prdoc
gpestana 27129fb
fixes clippy
gpestana f0098d6
Fixes clippy
gpestana fa94b7f
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana f89a046
after master merge fixes
gpestana 18f11b7
simplify on_remove_* logic
gpestana 0e95378
Adds stake-tracker to benchmarking runtime
gpestana ff8a64e
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 261e8ab
stake-tracker cargo fix
gpestana 63f43f8
Fixes stake-tracker/no-std
gpestana bc2f2ce
Fixes feature dependencies
gpestana 50ea3d0
fmt cargo.toml
gpestana 38e6616
fixes westend/stake-tracker runtime config
gpestana 5a5494a
impls max_exposure_page_size for mock (runtime-benchmarks)
gpestana 246c49a
fixes rust docs
gpestana 41a00a3
Adds throughout try-state checks and includes stake-tracker try-state…
gpestana 3ae6d11
Update substrate/frame/staking/src/ledger.rs
gpestana cf047db
fixes clippy
gpestana 6e5d019
clean up try-state code
gpestana d12cdc2
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana a1b16c7
clippy nits
gpestana f48c7de
Add try-runtime gated method in sorted list provider to help with checks
gpestana 4ac7fcf
Adds the callable drop_dangling_nomination to allow permissionless dr…
gpestana 2fdb673
clippy
gpestana e5ca233
doc fixes
gpestana 786dbf5
simplifies staking imbalance calculation; addresses reviews
gpestana bfa02dc
Update substrate/frame/staking/stake-tracker/src/lib.rs
gpestana 44f44ef
addresses PR comments & simplifies stake-tracker code
gpestana ff8ee33
add a couple more checks to try-state when building the approvals map
gpestana 740565b
ensures OnStakingUpdate events are triggered at the correct places an…
gpestana 8c8d004
updates comments; ensures that voter list is also always sorted + tes…
gpestana d48f823
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 639edaf
nits and address comments
gpestana 9af1122
defensive instead of err in case of killing a stash that is not Idle
gpestana 7dd813b
Adds stake-tracker benchs
gpestana 9ec7759
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana ab802b5
Removes the need for staking to check the state of the target and vot…
gpestana 12fce24
cargo-clippy fix
gpestana d44f734
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana afeddd2
Update substrate/frame/staking/stake-tracker/src/lib.rs
gpestana e66d00f
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 56ecb62
starts adding mmb for target list
gpestana 595022e
moves drop_dangling_target extrinsic from stake-tracker to staking
gpestana fa7edf1
finishes dangling nomination benchs
gpestana b4f9e90
fixes BadTarget error in benchmarks
gpestana 803f148
Adds v13 mmb migration benchmarks and tests
gpestana 6123e12
refactors benchmarks to use benchmarking::v2
gpestana 25589af
some refactoring on mmb benchmarks
gpestana 7e6db9e
changes mmb strategy -- do nominator-based migrations instead of vali…
gpestana 2864631
Finishes benchmarks and MMB for stake-tracker
gpestana b01f013
simplifies defensive for tests only
gpestana ac5df15
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 34c4612
nit
gpestana 6273d4c
nits
gpestana 2096b25
fixes imports
gpestana 1080cc4
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
c6593dc
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
605e54d
starts sorting mode
gpestana 3fa1601
fixes iter
gpestana 9d335ca
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 9e18a84
cargo lock update after merging master
gpestana 40620e0
Update substrate/frame/staking/stake-tracker/src/lib.rs
gpestana 97d254e
Update substrate/frame/staking/stake-tracker/src/mock.rs
gpestana 8624320
nit
gpestana 6e452e1
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana e9218b6
nits
gpestana 1dd4d38
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 628bceb
`stake-tracker` feedback PR (#4411)
gpestana 52cde8a
Merge branch 'gpestana/stake-tracker_integration' of github.com:parit…
gpestana c444174
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana d726d0f
fixes zepter
gpestana 3d4452f
ensures mmb bench checks are deteministic
gpestana d225176
clippy nits
gpestana a56f765
taplo nit fixes
gpestana 80895ad
clippy nit
gpestana 6219b32
Stake tracker improvements (migration and try-state checks OK in Polk…
gpestana 822a945
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 1aa1c80
fixes umbrella runtime and stake-tracker mock after master merge
gpestana 4bf868a
nits
gpestana 3a07d09
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
1445118
docs pass
gpestana e785621
nit: fix umbrella cargo lint
gpestana 8c685d7
fixes nomination pools benchmarks (validators must exist)
gpestana c34ede1
adds try-state checks to ensure no duplicate targets in nomination
gpestana 303b4be
fixes tests and mocks in other pallets
gpestana 66290a6
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana cc16579
semver nits
gpestana fc39f8e
all try-state checks pass for ext pallets; prdoc nits
gpestana f2613de
nit
gpestana 8caac45
on_add_validator without option
gpestana b44a4e5
doc improvements; drop dangling target fix; more tests
gpestana 3a68c14
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 66f8259
addresses review
gpestana ea9e838
simplifies dedup
gpestana 4c79d3b
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana b3bd4fd
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 0fda93d
compilation nits after merge; addresses review comments.
gpestana 62a3e5c
removes unecessary staking::status calls in stake-tracker
gpestana d08cf70
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 19abad8
merge nits: removes sp_std
gpestana cb631fa
fixes dependencies on mmbs without sp_std
gpestana 9219e2e
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana f591b89
use crv2 in stake-tracker mock
gpestana 8b0dec2
Improves MMB docs and naming
gpestana a0d3962
stake-tracker cargo toml to use workspace
gpestana 4f90672
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana 4ddff0f
".git/.scripts/commands/fmt/fmt.sh"
aab02ce
nit to prevent defensives in migration
gpestana 06b6821
Merge branch 'gpestana/stake-tracker_integration' of github.com:parit…
gpestana 933e159
Adds target approvals buffering below a threshold (#5168)
gpestana 24c4faa
Revert "Adds target approvals buffering below a threshold" (#5235)
gpestana 1b6d567
Merge branch 'master' into gpestana/stake-tracker_integration
gpestana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the distribution of initial validators in these bags good? We could go for a different bag distribution for targets, given that approval stakes are generally much higher. Just an option.