Use a worker pool to process ApprovalDistribution messages
#1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…reim/refactor-approval-checking Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim
added
T0-node
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
2 tasks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…tytech#1941) * actually clone client data by reference when clonning the client * spelling * clippy
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* actually clone client data by reference when clonning the client * spelling * clippy
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged to feature branch: https://github.com/paritytech/polkadot-sdk/tree/sandreim/network_scalability
The first step for implementing #1617
High level changes:
subsystem-utilapproval-distributionsubsystem to use a thread pool for processing the messagesImportant: there are no logic changes and this is mostly plumbing work.
At this stage I want to gather more feedback on the approach in this PR and also for how to do the same for
approval-voting. I currently see two options:approval-distributionworkerapproval-votinglogicWhat's missing in this PR: