remove gum dependency on jaeger #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Nov 1, 2023
|
I had previously used It doesn't look like this PR actually cut down on the number of syscalls in the binaries, which is good. It means that LTO was working well and not including unused code. |
s0me0ne-unkn0wn
approved these changes
Nov 1, 2023
mrcnski
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
I experimented with removing all the log lines and the gum dependency, verifying that it didn't appear in cargo tree output anymore. However, this didn't decrease the detected syscalls at all. So we can keep gum, and as far as I know there is no other dependency that can be removed like we did with tokio - therefore I'm closing the linked issue.
Thank you very much @jpserrat for the cleanup and your continued contributions. ⭐️
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Use generated runtimes for BHR/BHW * Deduplicate BHR/BHW runtimes * Add script for regenerating runtimes
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested,
tracing-gumonly relies on one function ofjaegerand the dependency can be removed by copying this function.Let me know if this is what you guys had in mind.
Closes #649