Implementation of validator disabling strategy in the runtime #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
tdimitrov
commented
Nov 6, 2023
| Ok(pos) => { | ||
| // Keep the biggest offence | ||
| if slash_proportion > offending[pos].1 { | ||
| offending[pos].1 = slash_proportion; |
There was a problem hiding this comment.
tdimitrov
commented
Nov 6, 2023
|
|
||
| let offending_threshold = | ||
| T::OffendingValidatorsThreshold::get() * validators.len() as u32; | ||
|
|
||
| if offending.len() >= offending_threshold as usize { | ||
| // force a new era, to select a new validator set | ||
| // force a new era, to select a new validator set. The era will be forced on the | ||
| // next session |
There was a problem hiding this comment.
tdimitrov
commented
Nov 6, 2023
| let mut rng = rand_chacha::ChaChaRng::from_seed(entropy.into()); | ||
|
|
||
| let mut indecies_to_remove = BTreeSet::new(); | ||
| for _ in 0..=desired_len.saturating_sub(validators.len()) { |
There was a problem hiding this comment.
tdimitrov
commented
Nov 6, 2023
| } | ||
| } | ||
|
|
||
| let disabled = if disabled.len() > LIMIT { |
There was a problem hiding this comment.
tdimitrov
commented
Nov 6, 2023
| remove_random_validators::<T>(disabled, LIMIT) | ||
| } else { | ||
| disabled | ||
| }; |
There was a problem hiding this comment.
4 tasks
tdimitrov
added
the
T8-polkadot
bkontur
pushed a commit
that referenced
this pull request
May 10, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 14, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 16, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 17, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 17, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 17, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 20, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
bkontur
pushed a commit
that referenced
this pull request
May 21, 2024
* backport cumulus changes to bridges-master * bump substrate, polkadot & cumulus * backport cumulus changes * make it build * fix runtimes: only numeric literals are supported by sp_version::runtime_version macro --------- Signed-off-by: acatangiu <adrian@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a recreation of #1214 which after the transfer includes some rogue commits. Fixing it is too much hassle (there are additional merges after that) so I'm recreating it.
The strategy is described in #784 (comment). This PR outlines an initial implementation with todos.
Related to #784
Link to the PR in the old substrate repo: paritytech/substrate#14697
Things that needs to be addressed: