Move cryptographic hashing procedures to crypto folder. #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM!
Is there a plan to handle older crates published on crates.io? Such developers know to which crates to migrate 🤔
For example, sp-core-hashing and others could be republished with an empty source code and the readme redirecting at the new ones on crates.io
michalkucharczyk
approved these changes
Nov 24, 2023
|
@davxy maybe you could update the pr. |
ggwpez
reviewed
Jan 20, 2024
Lederstrumpf
approved these changes
Jan 22, 2024
Co-authored-by: Robert Hambrock <roberthambrock@gmail.com>
This was referenced Jan 23, 2024
Closed
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
) Step towards paritytech#1975 As reported paritytech#1975 (comment) I'd like to encapsulate crypto related stuff in a dedicated folder. Currently all cryptographic primitive wrappers are all sparsed in `substrate/core` which contains "misc core" stuff. To simplify the process, as the first step with this PR I propose to move the cryptographic hashing there. The `substrate/crypto` folder was already created to contains `ec-utils` crate. Notes: - rename `sp-core-hashing` to `sp-crypto-hashing` - rename `sp-core-hashing-proc-macro` to `sp-crypto-hashing-proc-macro` - As the crates name is changed I took the freedom to restart fresh from version 0.1.0 for both crates --------- Co-authored-by: Robert Hambrock <roberthambrock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards #1975
As reported #1975 (comment) I'd like to encapsulate crypto related stuff in a dedicated folder.
Currently all cryptographic primitive wrappers are all sparsed in
substrate/corewhich contains "misc core" stuff.To simplify the process, as the first step with this PR I propose to move the cryptographic hashing there.
The
substrate/cryptofolder was already created to containsec-utilscrate.Notes:
sp-core-hashingtosp-crypto-hashingsp-core-hashing-proc-macrotosp-crypto-hashing-proc-macroDeprecation
sp-core-hashingandsp-core-hashing-proc-pacrowere moved tosubstrate/deprecatedfolder with removal scheduled to Jun 2024