Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix test-frame-ui job #2672

Merged
merged 2 commits into from
Dec 10, 2023
Merged

[ci] fix test-frame-ui job #2672

merged 2 commits into from
Dec 10, 2023

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Dec 10, 2023

The test frame ui started failing consistently on latest master [1]. I assume it was because of a race between
#1343 which introduced this warning and a PR that updated our tooling version, hence the warnings don't match perfectly, so regenerated them with TRYBUILD=overwrite as the test suggests.

[1] https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4666766

The test frame ui started failing consistently on latest master [1]. I
assume it was because of a race between
#1343 which introduced
this warning and a PR that updated our tooling version, hence the
warnings don't match perfectly, so regenerated them with
`TRYBUILD=overwrite` as the test suggests.

[1] https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4666766

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh requested review from a team December 10, 2023 13:29
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Dec 10, 2023
@bkchr bkchr merged commit e5dc8ed into master Dec 10, 2023
119 of 123 checks passed
@bkchr bkchr deleted the alexaggh/fix/test-frame-ui branch December 10, 2023 21:22
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
The test frame ui started failing consistently on latest master [1]. I
assume it was because of a race between
paritytech#1343 which introduced
this warning and a PR that updated our tooling version, hence the
warnings don't match perfectly, so regenerated them with
`TRYBUILD=overwrite` as the test suggests.

[1] https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4666766

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants