pallet-contracts: Fix compilation on latest nightly #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently they changed detection for visibility identifiers on traits, which broke more than it should. There is an issue open: rust-lang/rust#119924 The easy solution for us is to move the declaration of the global variable outside of the trait. Closes: #2960
2 tasks
pgherveou
approved these changes
Jan 18, 2024
athei
approved these changes
Jan 18, 2024
Yes only in traits AFAIK. |
|
As the relevant rustc dev speaking, sorry for the inconvenience, I will fix this as soon as possible when time permits. |
pmikolajczyk41
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Feb 21, 2024
Apparently they changed detection for visibility identifiers on traits, which broke more than it should. There is an issue open: rust-lang/rust#119924 The easy solution for us is to move the declaration of the global variable outside of the trait. Closes: paritytech#2960 (cherry picked from commit 0e124a0)
pmikolajczyk41
added a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Feb 21, 2024
smohan-dw
pushed a commit
to dhiway/substrate-sdk
that referenced
this pull request
Mar 2, 2024
lesniak43
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Mar 18, 2024
lesniak43
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Mar 18, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Apparently they changed detection for visibility identifiers on traits, which broke more than it should. There is an issue open: rust-lang/rust#119924 The easy solution for us is to move the declaration of the global variable outside of the trait. Closes: paritytech#2960
lesniak43
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
lesniak43
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
Apr 22, 2024
lesniak43
pushed a commit
to Cardinal-Cryptography/polkadot-sdk
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently they changed detection for visibility identifiers on traits, which broke more than it should. There is an issue open: rust-lang/rust#119924 The easy solution for us is to move the declaration of the global variable outside of the trait.
Closes: #2960