Backport of fix Pools 6->7 migration (#2942) #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
ggwpez
approved these changes
Jan 29, 2024
kianenigma
approved these changes
Feb 1, 2024
acatangiu
approved these changes
Feb 1, 2024
gpestana
approved these changes
Feb 1, 2024
|
I think the issue is that the CI not runs with 1.75 but originally this was merged with 1.74. Maybe you can just merge that 1.75 update to make it green. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
cc paritytech/ci_cd#900 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>
bkontur
force-pushed
the
bko-pools-migration-fix-to-1.5
branch
from
eff6512
to
353a7b2
Compare
ehm, thank you, I missed your comment :D, so I reverted all the mess and cherry-picked commit with 1.74 for CI and it looks like at least clippy is ok now |
For some reason original PR passed CI - when it shouldn't have. Fix `pallet-xcm` test benchmarks.
|
@ggwpez do you have another tips for the failed jobs? or we are good to go without them? |
8 tasks
|
We now need to do the same for 1.6.0, right? |
yes, but this #3093 has been already merged last week |
bkontur
added a commit
that referenced
this pull request
Feb 6, 2024
This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com>
acatangiu
added a commit
that referenced
this pull request
Feb 12, 2024
This is a cherry-pick of #3094 (patch to `release-polkadot-v1.5.0`). This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: command-bot <>
bkchr
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Feb 14, 2024
Attached result of `cargo upgrade -v --pinned --incompatible` [cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/13873056/cargo-upgrade-version-bump.log) E.g.: `frame-support` from `25.0.0` to `27.0.0` _Note: Encointer was not upgraded (because its pallet references `polkadot@1.3.0` release)._ ## TODO - [x] fix compilation - [x] fix integration tests - [x] fix benchmarks (also try them) - [ ] patch for `pallet-nomination-pools` migration fix paritytech/polkadot-sdk#3094 - [x] patch for `xcm-executor` fix paritytech/polkadot-sdk#3174 - [x] search for `TODO:(PR#137) - wait for xcm-executor patch` (missing `FrameTransactionalProcessor`) - [x] check/verify `MaxExposurePageSize = 512` / `MaxNominators = 512` for Kusama/Polkadot - [x] check with SRLabs (Jakob) paritytech-secops/srlabs_findings#327 Closes: #113 --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result as a patched
24.0.1version for https://crates.io/crates/pallet-nomination-pools/24.0.0.Relates to: polkadot-fellows/runtimes#137