subsystem-bench: polish imports #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
added
R0-silent
sandreim
approved these changes
Feb 9, 2024
alindima
approved these changes
Feb 9, 2024
| @@ -287,7 +210,6 @@ fn main() -> eyre::Result<()> { | |||
| .filter(Some("polkadot_overseer"), log::LevelFilter::Error) | |||
| .filter(None, log::LevelFilter::Info) | |||
| .format_timestamp_millis() | |||
| // .filter(None, log::LevelFilter::Trace) | |||
There was a problem hiding this comment.
I think this was left intentionally for easier debugging
There was a problem hiding this comment.
It looks like a leftover :-)
| DataAvailabilityWrite, | ||
| /// Benchmark the approval-voting and approval-distribution subsystems. | ||
| ApprovalVoting(ApprovalsOptions), | ||
| Unimplemented, |
There was a problem hiding this comment.
why do we have unimplemented?
There was a problem hiding this comment.
Can't answer the question. It's not a part of my PR after I rebased the branch. And It was not me who implemented it before.
AndreiEres
force-pushed
the
AndreiEres/subsystem-bench/polish-imports
branch
from
2b6081a to
b518491
Compare
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.