Assets: can_decrease/increase for destroying asset is not successful #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
changed the title
acatangiu
approved these changes
Feb 12, 2024
georgepisaltu
approved these changes
Feb 12, 2024
| @@ -132,6 +132,9 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
| Some(details) => details, | |||
| None => return DepositConsequence::UnknownAsset, | |||
| }; | |||
| if details.status == AssetStatus::Destroying { | |||
There was a problem hiding this comment.
nit: I'd use matches! instead of ==. Same for usage below.
There was a problem hiding this comment.
what's the benefit? with == I follow the style within the function
There was a problem hiding this comment.
Pattern matching is the standard way of comparing enums and it doesn't require PartialEq/Eq, but in this case it's not a big deal.
joepetrowski
approved these changes
Feb 12, 2024
liamaharon
approved these changes
May 17, 2024
|
@muharem what is the status of this pr? |
I did add it to the backlog for audit. But it is ready to be merged. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
bot merge |
|
@muharem |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomaszWaszczyk
pushed a commit
to TomaszWaszczyk/polkadot-sdk
that referenced
this pull request
Jul 7, 2024
…aritytech#3286) Functions `can_decrease` and `can_increase` do not return successful consequence results for assets undergoing destruction; instead, they return the `UnknownAsset` consequence variant. This update aligns their behavior with similar functions, such as `reducible_balance`, `increase_balance`, `decrease_balance`, and `burn`, which return an `AssetNotLive` error for assets in the process of being destroyed.
ordian
added a commit
that referenced
this pull request
Jul 15, 2024
* master: (120 commits) network/tx: Ban peers with tx that fail to decode (#5002) Try State Hook for Bounties (#4563) [statement-distribution] Add metrics for distributed statements in V2 (#4554) added sync command (#4818) Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935) xcm-executor: Improve logging (#4996) Remove usage of `sp-std` on templates (#5001) fixed cmd bot commenting not working (#5000) Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template (#4941) Expose metadata-hash feature from polkadot crate (#4886) Add `MAX_INSTRUCTIONS_TO_DECODE` to XCMv2 (#4978) add notices to the implementer's guide docs that changed for elastic scaling (#4983) `polkadot-parachain` simplifications and deduplications (#4916) Update Templates README docs (#4980) allow clear_origin in safe xcm builder (#4777) litep2p/peerstore: Fix bump last updated time (#4971) Make `tracing::log` work in the runtime (#4863) sp-core: Improve docs generated by `generate_feature_enabled_macro` (#4968) [Backport] Version bumps and prdocs reordering from 1.14.0 (#4955) Assets: can_decrease/increase for destroying asset is not successful (#3286) ...
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…aritytech#3286) Functions `can_decrease` and `can_increase` do not return successful consequence results for assets undergoing destruction; instead, they return the `UnknownAsset` consequence variant. This update aligns their behavior with similar functions, such as `reducible_balance`, `increase_balance`, `decrease_balance`, and `burn`, which return an `AssetNotLive` error for assets in the process of being destroyed.
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
can_decreaseandcan_increasedo not return successful consequence results for assets undergoing destruction; instead, they return theUnknownAssetconsequence variant.This update aligns their behavior with similar functions, such as
reducible_balance,increase_balance,decrease_balance, andburn, which return anAssetNotLiveerror for assets in the process of being destroyed.