-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parachain upgrade scheduling when done by the owner/root #3341
Merged
Commits on Feb 15, 2024
-
Fix parachain upgrade scheduling when done by the owner/root
When using `schedule_code_upgrade` to change the code of a parachain in the relay chain runtime, we had already fixed to not set the `GoAhead` signal. This was done to not brick any parachain after the upgrade, because they were seeing the signal without having any upgrade prepared. The remaining problem is that the parachain code is only upgraded after a parachain header was enacted, aka the parachain made some progress. However, this is quite complicated if the parachain is bricked (which is the most common scenario why to manually schedule a code upgrade). Thus, this pull request replaces `SetGoAhead` with `EnactUpgradeDirectly` to signal to the logic that we don't want to set the go ahead signal and that we want to replace the current parachain code directly without waiting for some progress of the parachain.
Configuration menu - View commit details
-
Copy full SHA for 62efdbd - Browse repository at this point
Copy the full SHA 62efdbdView commit details
Commits on Mar 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 81dac98 - Browse repository at this point
Copy the full SHA 81dac98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0669c62 - Browse repository at this point
Copy the full SHA 0669c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for e27bf59 - Browse repository at this point
Copy the full SHA e27bf59View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2c11220 - Browse repository at this point
Copy the full SHA 2c11220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b8169b - Browse repository at this point
Copy the full SHA 1b8169bView commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for abddbf5 - Browse repository at this point
Copy the full SHA abddbf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 703c557 - Browse repository at this point
Copy the full SHA 703c557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7460d78 - Browse repository at this point
Copy the full SHA 7460d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 334c419 - Browse repository at this point
Copy the full SHA 334c419View commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b6b6a6f - Browse repository at this point
Copy the full SHA b6b6a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50feb0c - Browse repository at this point
Copy the full SHA 50feb0cView commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c27b265 - Browse repository at this point
Copy the full SHA c27b265View commit details -
Merge branch 'bkchr-go-ahead-fix' of github.com:paritytech/polkadot-s…
…dk into bkchr-go-ahead-fix
Configuration menu - View commit details
-
Copy full SHA for ae975b6 - Browse repository at this point
Copy the full SHA ae975b6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.