Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parachain upgrade scheduling when done by the owner/root #3341

Merged
merged 14 commits into from
Apr 2, 2024

Commits on Feb 15, 2024

  1. Fix parachain upgrade scheduling when done by the owner/root

    When using `schedule_code_upgrade` to change the code of a parachain in
    the relay chain runtime, we had already fixed to not set the `GoAhead`
    signal. This was done to not brick any parachain after the upgrade,
    because they were seeing the signal without having any upgrade prepared.
    The remaining problem is that the parachain code is only upgraded after
    a parachain header was enacted, aka the parachain made some progress.
    However, this is quite complicated if the parachain is bricked (which is
    the most common scenario why to manually schedule a code upgrade). Thus,
    this pull request replaces `SetGoAhead` with `EnactUpgradeDirectly` to
    signal to the logic that we don't want to set the go ahead signal and
    that we want to replace the current parachain code directly without
    waiting for some progress of the parachain.
    bkchr committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    62efdbd View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Rework per feedback

    bkchr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    81dac98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0669c62 View commit details
    Browse the repository at this point in the history
  3. FMT

    bkchr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e27bf59 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Rework some docs

    bkchr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2c11220 View commit details
    Browse the repository at this point in the history
  2. PRDOC

    bkchr committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1b8169b View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Code review

    bkchr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    abddbf5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    703c557 View commit details
    Browse the repository at this point in the history
  3. Stuff

    bkchr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7460d78 View commit details
    Browse the repository at this point in the history
  4. 🙈

    bkchr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    334c419 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. I'M DUMB

    bkchr committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b6b6a6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50feb0c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Extend the test

    bkchr committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c27b265 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'bkchr-go-ahead-fix' of github.com:paritytech/polkadot-s…

    …dk into bkchr-go-ahead-fix
    bkchr committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ae975b6 View commit details
    Browse the repository at this point in the history