ProposerFactory impl Clone #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would propose this way :D |
Ok, I manually implemented |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Feb 21, 2024
| include_proof_in_block_size_estimation: self | ||
| .include_proof_in_block_size_estimation | ||
| .clone(), | ||
| _phantom: self._phantom.clone(), |
There was a problem hiding this comment.
Suggested change
| _phantom: self._phantom.clone(), | |
| _phantom: self._phantom, |
Comment on lines
194
to
198
|
|
||
| /// Set metrics. | ||
| pub fn set_metrics(&mut self, metrics: PrometheusMetrics) { | ||
| self.metrics = metrics; | ||
| } |
There was a problem hiding this comment.
Suggested change
| /// Set metrics. | |
| pub fn set_metrics(&mut self, metrics: PrometheusMetrics) { | |
| self.metrics = metrics; | |
| } |
This reverts commit fb10844.
tmpolaczyk
changed the title
davxy
approved these changes
Feb 21, 2024
skunert
approved these changes
Feb 21, 2024
Merged
via the queue into
paritytech:master
with commit Feb 21, 2024
318fed3
131 of 132 checks passed
girazoki
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Feb 22, 2024
In Tanssi, we need a way to stop the collator code and then start it again. This is to support rotating the same collator between different runtimes. Currently, this works very well, except for the proposer metrics, because they only get registered the first time they are started. Afterwards, we see this warning log: > Failed to register proposer prometheus metrics: Duplicate metrics collector registration attempted ~~So this PR adds a method to set metrics, to allow us to register metrics manually before creating the `ProposerFactory`, and then clone the same metrics every time we need to start the collator.~~ Implemented Clone instead
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
In Tanssi, we need a way to stop the collator code and then start it again. This is to support rotating the same collator between different runtimes. Currently, this works very well, except for the proposer metrics, because they only get registered the first time they are started. Afterwards, we see this warning log: > Failed to register proposer prometheus metrics: Duplicate metrics collector registration attempted ~~So this PR adds a method to set metrics, to allow us to register metrics manually before creating the `ProposerFactory`, and then clone the same metrics every time we need to start the collator.~~ Implemented Clone instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tanssi, we need a way to stop the collator code and then start it again. This is to support rotating the same collator between different runtimes. Currently, this works very well, except for the proposer metrics, because they only get registered the first time they are started. Afterwards, we see this warning log:
So this PR adds a method to set metrics, to allow us to register metrics manually before creating theImplemented Clone insteadProposerFactory, and then clone the same metrics every time we need to start the collator.