Repot all templates into a single directory #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
T1-FRAME
gupnik
approved these changes
Feb 23, 2024
| @@ -0,0 +1,35 @@ | |||
| //! Benchmarking setup for pallet-template | |||
There was a problem hiding this comment.
These files didn't have a license header beforehand, not adding them here to minimize diff, but it is a follow-up.
There was a problem hiding this comment.
Maybe worth adding something here for the templates:
|
merge issues are due to #3002 |
EgorPopelyaev
approved these changes
Feb 29, 2024
kianenigma
added
the
R0-silent
|
CI Leftover that needs adjusting: polkadot-sdk/.gitlab/pipeline/check.yml Line 22 in 35349df |
skunert
approved these changes
Feb 29, 2024
kianenigma
removed
the
R0-silent
ggwpez
reviewed
Feb 29, 2024
ggwpez
approved these changes
Feb 29, 2024
michalkucharczyk
approved these changes
Feb 29, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
The first step towards paritytech#3155 Brings all templates under the following structure ``` templates | parachain | | polkadot-launch | | runtime --> parachain-template-runtime | | pallets --> pallet-parachain-template | | node --> parachain-template-node | minimal | | runtime --> minimal-template-runtime | | pallets --> pallet-minimal-template | | node --> minimal-template-node | solochain | | runtime --> solochain-template-runtime | | pallets --> pallet-template (the naming is not consistent here) | | node --> solochain-template-node ``` The only note-worthy changes in this PR are: - More `Cargo.toml` fields are forwarded to use the one from the workspace. - parachain template now has weights and benchmarks - adds a shell pallet to the minimal template - remove a few unused deps A list of possible follow-ups: - [ ] Unify READMEs, create a parent README for all - [ ] remove references to `docs.substrate.io` in templates - [ ] make all templates use `#[derive_impl]` - [ ] update and unify all licenses - [ ] Remove polkadot launch, use https://github.com/paritytech/polkadot-sdk/blob/35349df993ea2e7c4769914ef5d199e787b23d4c/cumulus/zombienet/examples/small_network.toml instead.
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step towards #3155
Brings all templates under the following structure
The only note-worthy changes in this PR are:
Cargo.tomlfields are forwarded to use the one from the workspace.A list of possible follow-ups:
docs.substrate.ioin templates#[derive_impl]