Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xcm config for coretime. #3768

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Fix xcm config for coretime. #3768

merged 7 commits into from
Mar 23, 2024

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Mar 20, 2024

Fixes #3762 .

@eskimor eskimor added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels Mar 20, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5588972

acatangiu
acatangiu approved these changes Mar 20, 2024
View reviewed changes
polkadot/runtime/westend/src/xcm_config.rs Outdated Show resolved Hide resolved
bkchr
bkchr reviewed Mar 20, 2024
View reviewed changes
polkadot/runtime/westend/src/xcm_config.rs Outdated
pub struct CollectivesOrFellows;
impl Contains<Location> for CollectivesOrFellows {
pub struct SystemOrFellows<ParaId>(PhantomData<ParaId>);
impl<ParaId: IsSystem + From<u32>> Contains<Location> for SystemOrFellows<ParaId> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this generic over ParaId?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do it this way: https://github.com/paritytech/polkadot-sdk/pull/3768/files#r1533610770
we dont need any generics here

polkadot/runtime/westend/src/xcm_config.rs Outdated Show resolved Hide resolved
@eskimor @acatangiu
Update polkadot/runtime/westend/src/xcm_config.rs
6fd21c9 
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@acatangiu acatangiu added this pull request to the merge queue Mar 23, 2024
Merged via the queue into master with commit 19490ab Mar 23, 2024
131 of 133 checks passed
@acatangiu acatangiu deleted the rk-fix-coretime-westend branch March 23, 2024 06:09
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@eskimor @acatangiu @dharjeezy
Fix xcm config for coretime. (paritytech#3768)
81bf5a9 
Fixes paritytech#3762 .

---------

Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkontur bkontur bkontur left review comments

@bkchr bkchr bkchr left review comments

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Westend not being able to process coretime messages
6 participants
@eskimor @paritytech-cicd-pr @franciscoaguirre @bkchr @bkontur @acatangiu