-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames frame
crate to polkadot-sdk-frame
#3813
Conversation
if we are going to do a rename, can we rename everything? e.g. all the |
I will keep this one confined to the frame crate but please open an issue for the others that you would like to be renamed. |
I think for the ones with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say just import the crate with package = "poladkto-sdk-frame"
and then the code more or less remain the same everywhere.
wdyt @ggwpez @liamaharon?
Similarly, in all template codes, we should still retain frame::prelude::*
etc.
…ik/frame-crate-rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the direction of allowing polkadot-sdk-frame
, and letting it be re-imported as frame
. need better tests to ensure exactly these two scenarios are supported
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
…ik/frame-crate-rename
Step in #3155 Needed for paritytech/eng-automation#6 This PR renames `frame` crate to `polkadot-sdk-frame` as `frame` is not available on crates.io --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Step in paritytech#3155 Needed for paritytech/eng-automation#6 This PR renames `frame` crate to `polkadot-sdk-frame` as `frame` is not available on crates.io --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Step in #3155
Needed for paritytech/eng-automation#6
This PR renames
frame
crate topolkadot-sdk-frame
asframe
is not available on crates.io