im-online removal final cleanup
#3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0me0ne-unkn0wn
added
R0-silent
s0me0ne-unkn0wn
requested review from
andresilva,
eskimor,
ordian,
bkchr and
ggwpez
ordian
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
I think we should remove this pallet after some time from Substrate and maybe find new maintainers in https://github.com/open-web3-stack/open-runtime-module-library or whoever wants to use it.
acatangiu
approved these changes
Apr 1, 2024
bkchr
approved these changes
Apr 1, 2024
Ank4n
pushed a commit
that referenced
this pull request
Apr 9, 2024
Rejoice! Rejoice! The story is nearly over. This PR removes stale migrations, auxiliary structures, and package dependencies, thus making Rococo and Westend totally free from any `im-online`-related stuff. `im-online` still stays a part of the Substrate node and its runtime: https://github.com/paritytech/polkadot-sdk/blob/0d9324847391e902bb42f84f0e76096b1f764efe/substrate/bin/node/runtime/src/lib.rs#L2276-L2277 I'm not sure if it makes sense to remove it from there considering that we're not removing `im-online` from FRAME. Please share your opinion.
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Rejoice! Rejoice! The story is nearly over. This PR removes stale migrations, auxiliary structures, and package dependencies, thus making Rococo and Westend totally free from any `im-online`-related stuff. `im-online` still stays a part of the Substrate node and its runtime: https://github.com/paritytech/polkadot-sdk/blob/0d9324847391e902bb42f84f0e76096b1f764efe/substrate/bin/node/runtime/src/lib.rs#L2276-L2277 I'm not sure if it makes sense to remove it from there considering that we're not removing `im-online` from FRAME. Please share your opinion.
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rejoice! Rejoice! The story is nearly over.
This PR removes stale migrations, auxiliary structures, and package dependencies, thus making Rococo and Westend totally free from any
im-online-related stuff.im-onlinestill stays a part of the Substrate node and its runtime:polkadot-sdk/substrate/bin/node/runtime/src/lib.rs
Lines 2276 to 2277 in 0d93248
im-onlinefrom FRAME. Please share your opinion.