Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevating pallet-slots to an Independent Crate #3911

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asiniscalchi
Copy link
Contributor

@asiniscalchi asiniscalchi commented Mar 30, 2024

Description

This PR separates pallet-slots into its own crate while keeping the refactor transparent to the code outside polkadot-runtime-common. By re-exporting the pallet in polkadot-runtime-common, external references remain unchanged, preserving backward compatibility and minimizing impact on the wider Polkadot codebase.

Changes Summary:

  • Crate Creation: Extracted pallet-slots to a standalone crate, including a dedicated Cargo.toml for dependencies and configurations.
  • Re-export in polkadot-runtime-common: To maintain existing code paths, pallet-slots is re-exported in polkadot-runtime-common, making the refactor invisible to external users.
  • Dependency Adjustments: Updated Cargo.toml in polkadot-runtime-common and top-level workspace to reflect the new crate path for pallet-slots.

This approach enhances modularity without requiring any changes from the rest of the Polkadot codebase.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5702216

@asiniscalchi asiniscalchi changed the title Refactor/extract slots Elevating pallet-slots to an Independent Crate Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants