-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-identity-migrator
Becomes a Separate Crate
#3914
pallet-identity-migrator
Becomes a Separate Crate
#3914
Conversation
The CI pipeline was cancelled due to failure one of the required jobs. |
Clippy is giving errors on this :
polkadot-sdk/polkadot/runtime/parachains/src/inclusion/mod.rs Lines 382 to 396 in 8d30534
What's the ratio of those params not being used ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a one-off crate that will be deleted soon, any effort here is pretty much wasted...
This PR separates
pallet-identity-migrator
into its own crate while keeping the refactor transparent to the code outsidepolkadot-runtime-common
. By re-exporting the pallet inpolkadot-runtime-common
, external references remain unchanged, preserving backward compatibility and minimizing impact on the wider Polkadot codebase.Changes Summary:
pallet-identity-migrator
to a standalone crate, including a dedicatedCargo.toml
for dependencies and configurations.polkadot-runtime-common
: To maintain existing code paths,pallet-identity-migrator
is re-exported inpolkadot-runtime-common
, making the refactor invisible to external users.Cargo.toml
inpolkadot-runtime-common
and top-level workspace to reflect the new crate path forpallet-identity-migrator
.This approach enhances modularity without requiring any changes from the rest of the Polkadot codebase.