-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc-beefy-consensus: Remove unneeded stream. #4015
Merged
Merged
Commits on Apr 6, 2024
-
sc-beefy-consensus: Remove unneeded stream.
The stream was just used to communicate from the validator the peer reports back to the gossip engine. Internally the gossip engine just forwards these reports to the networking engine. So, we can just do this directly. The reporting stream was also pumped [in the worker behind the engine](https://github.com/paritytech/polkadot-sdk/blob/9d6261892814fa27c97881c0321c008d7340b54b/substrate/client/consensus/beefy/src/worker.rs#L939). This means if there was a lot of data incoming over the engine, the reporting stream was almost never processed and thus, it could have started to grow and we have seen issues around this. Closes: #3945
Configuration menu - View commit details
-
Copy full SHA for a58d0a9 - Browse repository at this point
Copy the full SHA a58d0a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f616b - Browse repository at this point
Copy the full SHA c5f616bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b313be2 - Browse repository at this point
Copy the full SHA b313be2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6121330 - Browse repository at this point
Copy the full SHA 6121330View commit details -
Configuration menu - View commit details
-
Copy full SHA for 105bf8e - Browse repository at this point
Copy the full SHA 105bf8eView commit details -
Merge branch 'bkchr-beefy-remove-unneeded-stream' of github.com:parit…
…ytech/polkadot-sdk into bkchr-beefy-remove-unneeded-stream
Configuration menu - View commit details
-
Copy full SHA for 7f1de72 - Browse repository at this point
Copy the full SHA 7f1de72View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04c38ee - Browse repository at this point
Copy the full SHA 04c38eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90d75fc - Browse repository at this point
Copy the full SHA 90d75fcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.