Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-beefy-consensus: Remove unneeded stream. #4015

Merged
merged 8 commits into from
Apr 8, 2024

Commits on Apr 6, 2024

  1. sc-beefy-consensus: Remove unneeded stream.

    The stream was just used to communicate from the validator the peer
    reports back to the gossip engine. Internally the gossip engine just
    forwards these reports to the networking engine. So, we can just do this
    directly.
    
    The reporting stream was also pumped [in the worker behind the
    engine](https://github.com/paritytech/polkadot-sdk/blob/9d6261892814fa27c97881c0321c008d7340b54b/substrate/client/consensus/beefy/src/worker.rs#L939).
    This means if there was a lot of data incoming over the engine, the
    reporting stream was almost never processed and thus, it could have
    started to grow and we have seen issues around this.
    
    Closes: #3945
    bkchr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a58d0a9 View commit details
    Browse the repository at this point in the history
  2. Make Davide happy :)

    bkchr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c5f616b View commit details
    Browse the repository at this point in the history
  3. Fix warning

    bkchr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    b313be2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6121330 View commit details
    Browse the repository at this point in the history
  5. ...

    bkchr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    105bf8e View commit details
    Browse the repository at this point in the history
  6. Merge branch 'bkchr-beefy-remove-unneeded-stream' of github.com:parit…

    …ytech/polkadot-sdk into bkchr-beefy-remove-unneeded-stream
    bkchr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    7f1de72 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. PRDOC

    bkchr committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    04c38ee View commit details
    Browse the repository at this point in the history
  2. Remove useless loop

    bkchr committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    90d75fc View commit details
    Browse the repository at this point in the history