-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarking: complete automatic weight sanity check PR #4020
base: master
Are you sure you want to change the base?
benchmarking: complete automatic weight sanity check PR #4020
Conversation
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Review required! Latest push from author must always be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve since its technically correct, just some small improvements possible.
comments are resolved: most of the logs are removed/simplified and logged only for failing extrinsics |
@ggwpez could you review it one last time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @kianenigma in case you also want to take a look.
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
hey @kianenigma would appreciate your review on this. thanks! |
should complete #1493
polkadot address: 16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT