Synchronize templates #4040
Merged
Synchronize templates #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
added
R0-silent
gupnik
approved these changes
Apr 10, 2024
AndWeHaveAPlan
approved these changes
Apr 11, 2024
alvicsam
reviewed
Apr 11, 2024
alvicsam
approved these changes
Apr 11, 2024
EgorPopelyaev
approved these changes
Apr 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substrate-developer-hub#3155What's inside
A job, that will take each of the three templates, yank them out of the monorepo workspace, and push to individual repositories (1, 2, 3).
In case the build/test does not succeed, a PR such as this one gets created instead.
I'm proposing a manual dispatch trigger for now - so we can test and iterate faster - and change it to fully automatic triggered by releases later.
The manual trigger looks like this:
How it works
The job replaces dependencies referenced by git with a reference to released crates using psvm.
It creates a new workspace for the template, and adapts what's needed from the
polkadot-sdkworkspace.See the results
The action has been tried out in staging, and the results can be observed here:
These are based on the
1.9.0release (usingrelease-crates-io-v1.9.0branch).