Snowbridge: deposit extra fee to beneficiary on Asset Hub #4175

yrong · 2024-04-17T12:39:36Z

Just the upper-stream for Snowfork#137 and more context there.

acatangiu · 2024-04-17T13:27:32Z

bridges/snowbridge/primitives/router/src/inbound/mod.rs

+					// Deposit both asset and fees to beneficiary so the fees will not get
+					// trapped. Another benefit is when fees left more than ED on AssetHub could be
+					// used to create the beneficiary account in case it does not exist.
+					DepositAsset { assets: Wild(All), beneficiary },


I believe whole XCM fails if the beneficiary account does not exist and the leftover fees do not satisfy ED... :(

Maybe add an SetErrorHandler and fall back to deposit just the assets if the wildcard one fails.

I recommend building a test or more to validate both happy and corner cases.

Thanks for review it.

fall back to deposit just the assets if the wildcard one fails.

Currently WETH or any foreign asset from Ethereum is created as non_sufficient, so the fall back won't help in this case.

the leftover fees do not satisfy ED

As mentioned in Snowfork#137 (comment), we'll ensure this won't happen.

building a test or more to validate both happy and corner cases.

Sure, I'll do that.

I would avoid using DepositAsset(Wild(All)) because it can be quite expensive, e.g on the AssetHub here: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/xcm/mod.rs#L33-L51. It's better to use either Wild(AllOfCounted(2)) to deposit both the asset and fees, or to use Definite([asset, fees]).

We encountered a very similar issue raised by the security audit team here: #3157, and there was also a recommendation to use SetAppendix to avoid potential trapping.

I recommend building a test or more to validate both happy and corner cases.

👆 💯

More tests added in
0a218c7

@bkontur I'm not sure SetAppendix will help in this case, the DepositAsset is the last instruction of the xcm and if any of the preceding instructions fails, we do want the xcm fail as a whole.

SetAppendix

if you put something in the holding register (e.g. WithdrawAsset...) and another instruction fails, then the assets are trapped. But if you use SetAppendix(DepositAssets and place it before the failing instruction, then assets won't be trapped in the case of error, but instead Deposited to some account, so no asset trapping.

But it depends case-by-case, I'm not saying that you need to use it, I am just saying that there is this possibility.

Thanks for the reminder. I'll let our team to double check though I do think DepositAsset should be the last instruction here.

@bkontur Confirmed that we don't need the SetAppendix. We'll just leave the asset trapped when error happens.

acatangiu · 2024-04-18T14:13:23Z

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

+#[test]
+fn send_token_from_ethereum_to_non_existent_account_on_asset_hub_with_sufficient_fee_but_do_not_satisfy_ed(
+) {
+	// On AH the xcm fee is 33_873_024 and the ED is 3_300_000
+	send_token_from_ethereum_to_asset_hub_with_fee([1; 32], 36_000_000);
+
+	AssetHubRococo::execute_with(|| {
+		type RuntimeEvent = <AssetHubRococo as Chain>::RuntimeEvent;
+
+		// Check that the token was received and issued as a foreign asset on AssetHub
+		assert_expected_events!(
+			AssetHubRococo,
+			vec![
+				RuntimeEvent::MessageQueue(pallet_message_queue::Event::Processed { success:false, .. }) => {},
+			]
+		);
+	});
+}


so it looks like it does fail, losing the ETH as well - was better off before when extra fees would just get trapped - at least then ETH always went through

I think you should do a SetErrorHandler(DepositAssets(JustEth)) so that if DepositAssets(AllCounted(2)) fails, you fall back to depositing just the ETH.

Later, when we have #4190 in XCMv5, we can simplify and just trap "unhandled" assets with no worries as they can be easily claimed.

Yeah, we do need the custom-asset-claimer feature. Currently it's quite a challenge to claim the trapped WETH if error happens.

@acatangiu In this commit I do add SetErrorHandler(DepositAssets(JustEth)), but it does not help as I mentioned because WETH is created as non_sufficient asset.

As you can see from the log the test send_token_from_ethereum_to_non_existent_account_on_asset_hub_with_sufficient_fee_but_do_not_satisfy_ed still fails and the xcm execution cost increased(as more instructions added).

So I'm not sure if it provides benefit here.

cargo test -p bridge-hub-rococo-integration-tests --lib tests::snowbridge::send_token_from_ethereum_to_non_existent_account_on_asset_hub_with_sufficient_fee_but_do_not_satisfy_ed -- --nocapture 2024-04-18T14:51:52.625030Z TRACE xcm::process_instruction: === ReceiveTeleportedAsset(Assets([Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) }])) 2024-04-18T14:51:52.625037Z TRACE xcm::ensure_can_subsume_assets: worst_case_holding_len: 1, holding_limit: 64 2024-04-18T14:51:52.625075Z TRACE xcm::contains: ConcreteAssetFromSystem asset: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) }, origin: Location { parents: 1, interior: X1([Parachain(1013)]) } 2024-04-18T14:51:52.625083Z TRACE xcm::fungible_adapter: can_check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) } 2024-04-18T14:51:52.625102Z TRACE xcm::fungible_adapter: check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) } 2024-04-18T14:51:52.625120Z TRACE xcm::fungibles_adapter: check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) } 2024-04-18T14:51:52.625128Z TRACE xcm::fungibles_adapter: check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) } 2024-04-18T14:51:52.625148Z TRACE xcm::fungibles_adapter: check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) } 2024-04-18T14:51:52.625155Z TRACE xcm::nonfungibles_adapter: check_in origin: Location { parents: 1, interior: X1([Parachain(1013)]) }, what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) }, context: XcmContext { origin: Some(Location { parents: 1, interior: X1([Parachain(1013)]) }), message_id: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], topic: None } 2024-04-18T14:51:52.625251Z TRACE xcm::process_instruction: === BuyExecution { fees: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(48000000) }, weight_limit: Limited(Weight { ref_time: 511962000, proof_size: 13757 }) } 2024-04-18T14:51:52.625291Z TRACE xcm::weight: UsingComponents::buy_weight weight: Weight { ref_time: 511962000, proof_size: 13757 }, payment: AssetsInHolding { fungible: {AssetId(Location { parents: 1, interior: Here }): 48000000}, non_fungible: {} }, context: XcmContext { origin: Some(Location { parents: 1, interior: X1([Parachain(1013)]) }), message_id: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], topic: None } 2024-04-18T14:51:52.625322Z TRACE xcm::process_instruction: === DescendOrigin(X1([PalletInstance(80)])) 2024-04-18T14:51:52.625333Z TRACE xcm::process_instruction: === UniversalOrigin(GlobalConsensus(Ethereum { chain_id: 11155111 })) 2024-04-18T14:51:52.625379Z TRACE xcm::process_instruction: === ReserveAssetDeposited(Assets([Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }])) 2024-04-18T14:51:52.625388Z TRACE xcm::ensure_can_subsume_assets: worst_case_holding_len: 2, holding_limit: 64 2024-04-18T14:51:52.625413Z TRACE xcm::contains: IsTrustedBridgedReserveLocationForConcreteAsset asset: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, origin: Location { parents: 2, interior: X1([GlobalConsensus(Ethereum { chain_id: 11155111 })]) }, universal_source: X2([GlobalConsensus(Rococo), Parachain(1000)]) 2024-04-18T14:51:52.625425Z TRACE xcm::contains: Case asset: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, origin: Location { parents: 2, interior: X1([GlobalConsensus(Ethereum { chain_id: 11155111 })]) } 2024-04-18T14:51:52.625437Z TRACE xcm::contains: IsForeignConcreteAsset asset: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, origin: Location { parents: 2, interior: X1([GlobalConsensus(Ethereum { chain_id: 11155111 })]) } 2024-04-18T14:51:52.625458Z TRACE xcm::process_instruction: === ClearOrigin 2024-04-18T14:51:52.625464Z TRACE xcm::process_instruction: === SetErrorHandler(Xcm([DepositAsset { assets: Definite(Assets([Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }])), beneficiary: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } }])) 2024-04-18T14:51:52.625474Z TRACE xcm::weight: WeightInfoBounds message: Xcm([DepositAsset { assets: Definite(Assets([Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }])), beneficiary: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } }]) 2024-04-18T14:51:52.625485Z TRACE xcm::process_instruction: === DepositAsset { assets: Wild(AllCounted(2)), beneficiary: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } } 2024-04-18T14:51:52.625523Z TRACE xcm::fungible_adapter: deposit_asset what: Asset { id: AssetId(Location { parents: 1, interior: Here }), fun: Fungible(2143334) }, who: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } 2024-04-18T14:51:52.625586Z TRACE xcm::execute: !!! ERROR: FailedToTransactAsset("Account cannot exist with the funds that would be given") 2024-04-18T14:51:52.625596Z TRACE xcm::execute: result: Err(ExecutorError { index: 7, xcm_error: FailedToTransactAsset("Account cannot exist with the funds that would be given"), weight: Weight { ref_time: 2241000, proof_size: 0 } }) 2024-04-18T14:51:52.625602Z TRACE xcm::process: origin: None, total_surplus/refunded: Weight { ref_time: 2241000, proof_size: 0 }/Weight { ref_time: 0, proof_size: 0 }, error_handler_weight: Weight { ref_time: 0, proof_size: 0 } 2024-04-18T14:51:52.625608Z TRACE xcm::process_instruction: === DepositAsset { assets: Definite(Assets([Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }])), beneficiary: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } } 2024-04-18T14:51:52.625659Z TRACE xcm::fungible_adapter: deposit_asset what: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, who: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } 2024-04-18T14:51:52.625670Z TRACE xcm::fungibles_adapter: deposit_asset what: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, who: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } 2024-04-18T14:51:52.625680Z TRACE xcm::fungibles_adapter: deposit_asset what: Asset { id: AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }), fun: Fungible(1000000) }, who: Location { parents: 0, interior: X1([AccountId32 { network: None, id: [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1] }]) } 2024-04-18T14:51:52.625817Z TRACE xcm::execute: !!! ERROR: FailedToTransactAsset("Account cannot be created") 2024-04-18T14:51:52.625824Z TRACE xcm::execute: result: Err(ExecutorError { index: 0, xcm_error: FailedToTransactAsset("Account cannot be created"), weight: Weight { ref_time: 0, proof_size: 0 } }) 2024-04-18T14:51:52.625829Z TRACE xcm::refund_surplus: total_surplus: Weight { ref_time: 2241000, proof_size: 0 }, total_refunded: Weight { ref_time: 0, proof_size: 0 }, current_surplus: Weight { ref_time: 2241000, proof_size: 0 } 2024-04-18T14:51:52.625834Z TRACE xcm::weight: UsingComponents::refund_weight weight: Weight { ref_time: 2241000, proof_size: 0 }, context: XcmContext { origin: None, message_id: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], topic: None }, available weight: Weight { ref_time: 511962000, proof_size: 13757 }, available amount: 45856666 2024-04-18T14:51:52.625892Z TRACE xcm::weight: UsingComponents::refund_weight amount to refund: 6976 2024-04-18T14:51:52.625902Z TRACE xcm::refund_surplus: total_refunded: Weight { ref_time: 2241000, proof_size: 0 } 2024-04-18T14:51:52.626082Z TRACE xcm::post_process: Trapping assets in holding register: AssetsInHolding { fungible: {AssetId(Location { parents: 1, interior: Here }): 2150310, AssetId(Location { parents: 2, interior: X2([GlobalConsensus(Ethereum { chain_id: 11155111 }), AccountKey20 { network: None, key: [135, 209, 247, 253, 254, 231, 246, 81, 250, 188, 139, 252, 182, 224, 134, 194, 120, 183, 122, 125] }]) }): 1000000}, non_fungible: {} }, context: XcmContext { origin: None, message_id: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], topic: None } (original_origin: Location { parents: 1, interior: X1([Parachain(1013)]) }) 2024-04-18T14:51:52.626174Z TRACE xcm::post_process: Execution errored at 0: FailedToTransactAsset("Account cannot be created") (original_origin: Location { parents: 1, interior: X1([Parachain(1013)]) }) 2024-04-18T14:51:52.626182Z TRACE xcm::process-message: XCM message execution incomplete, used weight: Weight(ref_time: 509721000, proof_size: 13757), error: FailedToTransactAsset("Account cannot be created") ...

yeah, that's right, it doesn't help since account doesn't exist and WETH can't count towards ED..

I guess we'll just have to trap for now

This reverts commit 3fd810c.

paritytech-cicd-pr · 2024-04-18T15:46:17Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5981019

yrong · 2024-04-22T10:41:50Z

Do I need to provide anything more for this PR get merged?

acatangiu · 2024-04-22T11:38:17Z

Do I need to provide anything more for this PR get merged?

Looks good to go to me. You just need a prdoc (example: https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_4118.prdoc)

yrong · 2024-04-23T01:43:39Z

@bkontur Any other concern or could you help to approve the PR?

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

…idge-hub-rococo/src/tests/snowbridge.rs Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

prdoc/pr_4175.prdoc

bkontur · 2024-04-25T11:43:53Z

bridges/snowbridge/primitives/router/src/inbound/mod.rs

+					// Deposit both asset and fees to beneficiary so the fees will not get
+					// trapped. Another benefit is when fees left more than ED on AssetHub could be
+					// used to create the beneficiary account in case it does not exist.
+					DepositAsset { assets: Wild(AllCounted(2)), beneficiary },


You could maybe add description before every instruction for let mut instructions = vec![ :)

One question: could you point me to the place or explain where asset_hub_fee and destination.fee is coming from? Is it withdrawn or burned somewhere on BH? Is it the user's money, or is it money from some sovereign account on BH? Or where does this money come from?

I think it can be specific (not sure if compiles):

Suggested change

DepositAsset { assets: Wild(AllCounted(2)), beneficiary },

DepositAsset {

assets: Definite(vec![asset, asset_hub_fee_asset].into())),

beneficiary

},

or maybe use total_fee_asset(dest_para_fee should be 0 in this branch) instead of asset_hub_fee_asset?

Don't you need to fix also DepositReserveAsset { branch?

// Deposit asset to beneficiary. DepositAsset { assets: Definite(asset.into()), beneficiary },

One question: could you point me to the place or explain where asset_hub_fee and destination.fee is coming from? Is it withdrawn or burned somewhere on BH? Is it the user's money, or is it money from some sovereign account on BH? Or where does this money come from?

My concern here is whether we should deposit unused fees directly to the beneficiary instead of depositing them into a sovereign account in the AH. If this is a valid scenario, then the process should resemble something like this:

DepositAsset { assets: Definite(vec![asset].into())), beneficiary}, DepositAsset { assets: Definite(vec![asset_hub_fee_asset].into())), beneficiary: LocationOfSomeSovereignAccountOnAssetHub},

where asset_hub_fee and destination.fee is coming from?

asset_hub_fee from https://github.com/Snowfork/snowbridge/blob/3f90b1619d0bdbec8f50b63185b3dcc632321019/contracts/src/storage/AssetsStorage.sol#L15 which is a configurable storage on Ethereum, we charge it from the user and make sure that it can cover the execution cost on AH.

destination.fee is always zero for AH.

whether we should deposit unused fees directly to the beneficiary

I think so, it's from end user and we do want to send the unused back to the user.

Don't you need to fix also DepositReserveAsset { branch?

Nope, that branch is for non-system parachain which may not accept AssetHub-DOT as fee asset, we're gonna to make some fix there later and this PR focus on AH only.

I think so, it's from end user and we do want to send the unused back to the user.

ok, cool, thank you :)

Don't you need to fix also DepositReserveAsset { branch?

Nope, that branch is for non-system parachain which may not accept AssetHub-DOT as fee asset, we're gonna to make some fix there later and this PR focus on AH only.

Ok, got it. I saw that you use Location::parent() here for fees.assetId, so that would be probably changed and/or Destination.fee: u128, let's see later.

So, I think using exact assets for DepositAsset, as suggested above, is not a bad idea (or maybe some exact counter of unique assetIds :))

Co-authored-by: Adrian Catangiu <adrian@parity.io>

yrong · 2024-04-26T01:29:27Z

@acatangiu Could you help to merge the PR? Good to know that we're gonna to make WETH as sufficient on AH. Though IMO this PR still make sense for any other non-sufficient asset from Ethereum.

acatangiu · 2024-04-26T12:50:10Z

@yrong please merge master for the CI fix

yrong · 2024-04-26T16:04:01Z

There is one CI task gitlab-check-runtime-migration-westend failed https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6071070 but seems not related to this PR.

Just the upper-stream for Snowfork#137 and more context there. --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

…#4175) Just the upper-stream for Snowfork#137 and more context there. --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Deposit fee to beneficiary

8f86f35

yrong marked this pull request as ready for review April 17, 2024 12:43

paritytech-review-bot bot requested a review from a team April 17, 2024 12:44

acatangiu reviewed Apr 17, 2024

View reviewed changes

E2E tests

0a218c7

paritytech-review-bot bot requested a review from a team April 18, 2024 12:58

acatangiu reviewed Apr 18, 2024

View reviewed changes

Add SetErrorHandler

3fd810c

paritytech-review-bot bot requested a review from a team April 18, 2024 14:57

Revert "Add SetErrorHandler"

db52103

This reverts commit 3fd810c.

Merge branch 'master' into deposit-fee-to-beneficiary

bf3856b

acatangiu approved these changes Apr 22, 2024

View reviewed changes

yrong added 2 commits April 22, 2024 21:47

Add prdoc

908442b

Merge branch 'master' into deposit-fee-to-beneficiary

54d8d4e

Merge branch 'master' into deposit-fee-to-beneficiary

dee6ecc

yrong requested a review from bkontur April 23, 2024 01:50

claravanstaden reviewed Apr 23, 2024

View reviewed changes

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

yrong and others added 2 commits April 23, 2024 15:10

Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…

76755f9

…idge-hub-rococo/src/tests/snowbridge.rs Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…

3eed3aa

…idge-hub-rococo/src/tests/snowbridge.rs Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

claravanstaden approved these changes Apr 25, 2024

View reviewed changes

Merge branch 'master' into deposit-fee-to-beneficiary

bd36b4d

acatangiu added the T15-bridges This PR/Issue is related to bridges. label Apr 25, 2024

acatangiu changed the title ~~Deposit extra fee to beneficiary on asset hub~~ Snowbridge: deposit extra fee to beneficiary on Asset Hub Apr 25, 2024

acatangiu approved these changes Apr 25, 2024

View reviewed changes

prdoc/pr_4175.prdoc Outdated Show resolved Hide resolved

prdoc/pr_4175.prdoc Outdated Show resolved Hide resolved

bkontur reviewed Apr 25, 2024

View reviewed changes

Update prdoc/pr_4175.prdoc

45481f9

Co-authored-by: Adrian Catangiu <adrian@parity.io>

Update prdoc/pr_4175.prdoc

3c7a66d

Co-authored-by: Adrian Catangiu <adrian@parity.io>

bkontur approved these changes Apr 25, 2024

View reviewed changes

yrong added 2 commits April 25, 2024 23:27

Merge branch 'master' into deposit-fee-to-beneficiary

3c1ac1a

Merge branch 'master' into deposit-fee-to-beneficiary

a194ca5

bkontur enabled auto-merge April 26, 2024 09:50

acatangiu disabled auto-merge April 26, 2024 10:09

acatangiu enabled auto-merge April 26, 2024 10:10

svyatonik approved these changes Apr 26, 2024

View reviewed changes

serban300 disabled auto-merge April 26, 2024 10:44

serban300 enabled auto-merge April 26, 2024 10:44

Merge branch 'master' into deposit-fee-to-beneficiary

b79bc16

serban300 added this pull request to the merge queue Apr 26, 2024

Merged via the queue into paritytech:master with commit d893cde Apr 26, 2024
138 of 139 checks passed

yrong mentioned this pull request Apr 29, 2024

Deposit fee to beneficiary Snowfork/polkadot-sdk#137

Closed

peterwht mentioned this pull request Aug 15, 2024

chore: upgrade to 1.12.0 r0gue-io/pop-node#193

Merged

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

yrong mentioned this pull request Sep 4, 2024

snowbridge: improve destination fee handling to avoid trapping fees dust #5563

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Snowbridge: deposit extra fee to beneficiary on Asset Hub #4175

Snowbridge: deposit extra fee to beneficiary on Asset Hub #4175

yrong commented Apr 17, 2024 •

edited

Loading

acatangiu Apr 17, 2024

yrong Apr 17, 2024 •

edited

Loading

bkontur Apr 17, 2024

bkontur Apr 17, 2024

yrong Apr 18, 2024

bkontur Apr 18, 2024

yrong Apr 18, 2024

yrong Apr 22, 2024

acatangiu Apr 18, 2024

yrong Apr 18, 2024 •

edited

Loading

acatangiu Apr 18, 2024

paritytech-cicd-pr commented Apr 18, 2024

yrong commented Apr 22, 2024

acatangiu commented Apr 22, 2024

yrong commented Apr 23, 2024

bkontur Apr 25, 2024 •

edited

Loading

bkontur Apr 25, 2024

bkontur Apr 25, 2024

yrong Apr 25, 2024

bkontur Apr 25, 2024

yrong commented Apr 26, 2024

acatangiu commented Apr 26, 2024

yrong commented Apr 26, 2024

Snowbridge: deposit extra fee to beneficiary on Asset Hub #4175

Snowbridge: deposit extra fee to beneficiary on Asset Hub #4175

Conversation

yrong commented Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

yrong Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yrong Apr 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paritytech-cicd-pr commented Apr 18, 2024

yrong commented Apr 22, 2024

acatangiu commented Apr 22, 2024

yrong commented Apr 23, 2024

bkontur Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yrong commented Apr 26, 2024

acatangiu commented Apr 26, 2024

yrong commented Apr 26, 2024

yrong commented Apr 17, 2024 •

edited

Loading

yrong Apr 17, 2024 •

edited

Loading

yrong Apr 18, 2024 •

edited

Loading

bkontur Apr 25, 2024 •

edited

Loading