WithMaxSize #4188
WithMaxSize #4188
Conversation
| @@ -48,6 +48,7 @@ pub trait ExecuteControllerWeightInfo { | |||
|
|
|||
| parameter_types! { | |||
| pub const MaxXcmEncodedSize: u32 = xcm::MAX_XCM_ENCODED_SIZE; | |||
| pub const MaxXcmEncodedSizeUsize: usize = xcm::MAX_XCM_ENCODED_SIZE as usize; | |||
There was a problem hiding this comment.
Not sure what's the best way to handle this
|
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
Please let me know what should I do with the changes in pallet-xcm
|
| } | ||
|
|
||
| pub fn value(self) -> T { | ||
| self.value |
There was a problem hiding this comment.
Could make sense to impl the Deref trait and mark with WrapperTypeEncode and WrapperTypeDecode.
|
I guess @franciscoaguirre you are the right person to ping? |
|
@xlc let me verify this fully fixes the issue please before putting in more effort here, can't promise to do it today, but latest Monday |
| if into.len() > self.remaining_len { | ||
| return Err("Not enough data to fill buffer".into()); | ||
| } | ||
| self.input.read(into) |
There was a problem hiding this comment.
| self.input.read(into) | |
| let res = self.input.read(into)?; | |
| self.remaining_len -= into.len(); | |
| Ok(res) |
We actually need to remove it from the remaining length :D
There was a problem hiding this comment.
I really need some tests XD
and do we need to remove it before the read or it wouldn’t matter?
There was a problem hiding this comment.
I thought about it. If this returns an error, I would assume that we bubble that up any way and the decoding failed.
|
lazy decode the Call will be a better way |
closes #4092
we may want to revert #3749
TODOs:
executeandsendin favor ofexecute_blobandsend_blob#3749 either fully or partially