Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staking] Not allow reap stash for virtual stakers #4311

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Apr 26, 2024

Related to #3905.

Since virtual stakers does not have a real balance, they should not be allowed to be reaped.

The proper reaping for agents slashed will be done in a separate PR.

@Ank4n Ank4n added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Apr 26, 2024
substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
substrate/frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
@Ank4n Ank4n enabled auto-merge April 29, 2024 14:21
@Ank4n Ank4n added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit 0031d49 Apr 29, 2024
137 of 139 checks passed
@Ank4n Ank4n deleted the ankan/staking/virtual-bond branch April 29, 2024 16:18
Morganamilo pushed a commit that referenced this pull request May 2, 2024
Related to #3905.

Since virtual stakers does not have a real balance, they should not be
allowed to be reaped.

The proper reaping for agents slashed will be done in a separate PR.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Related to paritytech#3905.

Since virtual stakers does not have a real balance, they should not be
allowed to be reaped.

The proper reaping for agents slashed will be done in a separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants