Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds benchmarking and try-runtime support in frame crate #4406

Merged
merged 5 commits into from
May 8, 2024
Merged

Adds benchmarking and try-runtime support in frame crate #4406

merged 5 commits into from
May 8, 2024

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented May 8, 2024

No description provided.

@gupnik gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label May 8, 2024
@gupnik gupnik requested a review from a team as a code owner May 8, 2024 04:26
kianenigma
kianenigma approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, but to be better an example create built with frame should actually have a benchmarking setup etc.

@gupnik
Copy link
Contributor Author

gupnik commented May 8, 2024

It is good, but to be better an example create built with frame should actually have a benchmarking setup etc.

Yeah, integrating in the minimal fork for PBA currently, but will add an example as well as a follow-up here.

@gupnik gupnik added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 37b1544 May 8, 2024
147 checks passed
@gupnik gupnik deleted the gupnik/frame-crate-update branch May 8, 2024 12:17
paritytech-ci pushed a commit that referenced this pull request May 8, 2024
@codekitz
Adds benchmarking and try-runtime support in frame crate (#4406)
b192624
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@codekitz @hitchhooker
Adds benchmarking and try-runtime support in frame crate (paritytech#…
e32b2ab 
…4406)
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@codekitz @TarekkMA
Adds benchmarking and try-runtime support in frame crate (paritytech#…
ab5d8d3 
…4406)
This was referenced Aug 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gupnik @kianenigma @liamaharon