Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustls: Disable logging #4426

Merged
merged 3 commits into from
May 10, 2024
Merged

rustls: Disable logging #4426

merged 3 commits into from
May 10, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 10, 2024

Disable logging of rustls to get rid off the following log lines:

Sending fatal alert BadCertificate

Upstream also removed them: rustls/rustls#1278

Closes: #3252

Disable logging of rustls to get rid off the following log lines:
```
Sending fatal alert BadCertificate
```

Upstream also removed them: rustls/rustls#1278
@bkchr bkchr requested a review from koute as a code owner May 10, 2024 08:09
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label May 10, 2024
@bkchr bkchr enabled auto-merge May 10, 2024 11:42
@bkchr bkchr added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 2ed0f3e May 10, 2024
147 of 149 checks passed
@bkchr bkchr deleted the bkchr-disable-rustls-logging branch May 10, 2024 12:27
@bLd75
Copy link

bLd75 commented May 21, 2024

@bkchr Just tested v1.12.0 node release, unfortunately the message is still printing (a lot at startup).

@bkchr
Copy link
Member Author

bkchr commented May 21, 2024

@bLd75 can you please run with -lrusttls=debug for a moment and show the logs with with the bad certificate error?

@bLd75
Copy link

bLd75 commented May 21, 2024

Sure I just did, nothing more than the messages, no extra debug message.
WARN tokio-runtime-worker rustls::conn: Sending fatal alert BadCertificate

Frequency of the message over 5 minutes at startup, on Polkadot.
image

Checked version twice
INFO main sc_cli::runner: ✌️ version 1.12.0-b4016902ac7

@bkchr
Copy link
Member Author

bkchr commented May 22, 2024

@bLd75 sorry! :D #4541 this should fixes now for sure.

@bLd75
Copy link

bLd75 commented May 22, 2024

Thanks @bkchr confirmed, message doesn't show up anymore.

@LukeWheeldon
Copy link

I'm still getting those 2024-05-26 16:25:49 Sending fatal alert BadCertificate

@bkchr
Copy link
Member Author

bkchr commented May 26, 2024

@LukeWheeldon did you read the comments above? That I created another pr and @bLd75 confirmed that this works.

@LukeWheeldon
Copy link

@bkchr apologies I added my comment too quickly.

hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Disable logging of rustls to get rid off the following log lines:
```
Sending fatal alert BadCertificate
```

Upstream also removed them: rustls/rustls#1278


Closes: paritytech#3252
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Disable logging of rustls to get rid off the following log lines:
```
Sending fatal alert BadCertificate
```

Upstream also removed them: rustls/rustls#1278


Closes: paritytech#3252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending fatal alert BadCertificate
6 participants