Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extrinsics count logging in frame-system #4461

Merged
merged 3 commits into from
May 15, 2024

Conversation

liuchengxu
Copy link
Contributor

@liuchengxu liuchengxu commented May 15, 2024

The storage item ExtrinsicIndex is already taken before the finalize() in note_finished_extrinsics(), rendering it's always 0 in the log. This commit fixes it by using the proper API for extrinsics count.

The storage item ExtrinsicIndex is already taken before the `finalize()`
in `note_finished_extrinsics()`, rendering it's always 0 in the log.
This commit fixes it by using the proper API for extrinsics count.
@liuchengxu liuchengxu requested a review from a team as a code owner May 15, 2024 03:27
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you.

@liamaharon liamaharon added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed R0-silent Changes should not be mentioned in any release notes labels May 15, 2024
@liamaharon
Copy link
Contributor

Could you please add a PRDoc @liuchengxu ?

@liuchengxu liuchengxu force-pushed the fix-extrisics-count-logging branch from cfb9330 to 02841a4 Compare May 15, 2024 09:10
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr bkchr enabled auto-merge May 15, 2024 11:56
@bkchr bkchr added this pull request to the merge queue May 15, 2024
Merged via the queue into paritytech:master with commit 404027e May 15, 2024
149 of 151 checks passed
@liuchengxu liuchengxu deleted the fix-extrisics-count-logging branch May 15, 2024 15:08
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
The storage item ExtrinsicIndex is already taken before the `finalize()`
in `note_finished_extrinsics()`, rendering it's always 0 in the log.
This commit fixes it by using the proper API for extrinsics count.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
liuchengxu added a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
The storage item ExtrinsicIndex is already taken before the `finalize()`
in `note_finished_extrinsics()`, rendering it's always 0 in the log.
This commit fixes it by using the proper API for extrinsics count.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
The storage item ExtrinsicIndex is already taken before the `finalize()`
in `note_finished_extrinsics()`, rendering it's always 0 in the log.
This commit fixes it by using the proper API for extrinsics count.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants