Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-externalities: rpc_child_get_keys to use paged scraping #4512

Merged
merged 1 commit into from
May 19, 2024

Conversation

liamaharon
Copy link
Contributor

Replace usage of deprecated substrate_rpc_client::ChildStateApi::storage_keys with substrate_rpc_client::ChildStateApi::storage_keys_paged.

Required for successful scraping of Aleph Zero state.

@liamaharon liamaharon added R0-silent Changes should not be mentioned in any release notes I2-bug The node fails to follow expected behavior. I5-enhancement An additional feature request. and removed I2-bug The node fails to follow expected behavior. labels May 17, 2024
@liamaharon liamaharon changed the title remote-externalities: rpc_child_get_keys to use paged scraping remote-externalities: rpc_child_get_keys to use paged scraping May 17, 2024
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general we should make it lazy to download keys just in time, but still cache them in a snapshot file for future re-use.

For moonbeam eg its impossible to use try-runtime-cli or similar.

@liamaharon liamaharon added this pull request to the merge queue May 19, 2024
Merged via the queue into master with commit e7b6d7d May 19, 2024
162 checks passed
@liamaharon liamaharon deleted the liam-remote-ext-paged-child-keys branch May 19, 2024 18:20
Ank4n pushed a commit that referenced this pull request May 21, 2024
…4512)

Replace usage of deprecated
`substrate_rpc_client::ChildStateApi::storage_keys` with
`substrate_rpc_client::ChildStateApi::storage_keys_paged`.

Required for successful scraping of Aleph Zero state.
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…aritytech#4512)

Replace usage of deprecated
`substrate_rpc_client::ChildStateApi::storage_keys` with
`substrate_rpc_client::ChildStateApi::storage_keys_paged`.

Required for successful scraping of Aleph Zero state.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…aritytech#4512)

Replace usage of deprecated
`substrate_rpc_client::ChildStateApi::storage_keys` with
`substrate_rpc_client::ChildStateApi::storage_keys_paged`.

Required for successful scraping of Aleph Zero state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants