Use aggregated types for RuntimeFreezeReason and better examples of MaxFreezes
#4615
Conversation
| @@ -222,13 +222,13 @@ pub mod pallet { | |||
| type ExistentialDeposit = ConstU64<1>; | |||
|
|
|||
| type ReserveIdentifier = (); | |||
| type FreezeIdentifier = (); | |||
| type FreezeIdentifier = Self::RuntimeFreezeReason; | |||
There was a problem hiding this comment.
Seems like there is still a few pallets that don't use TestDefaultConfig, reasonable to update them as a part of this PR?
There was a problem hiding this comment.
Seems like there is still a few pallets that don't use
TestDefaultConfig, reasonable to update them as a part of this PR?
yes, good point, I will do that here
There was a problem hiding this comment.
@kianenigma I updated all (hopefully) pallets for pallet_balances::Config and TestDefaultConfig, please take a look
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| impl pallet_balances::Config for Test { | ||
| type MaxLocks = (); |
There was a problem hiding this comment.
HELL YEAH, thank you for moving all of this to derive_impl!
* master: [Backport] Version bumps and prdoc reorg from 1.13.0 (#4784) Add `--version` to the `ChainSpecBuilder` command for `staging-chain-spec-builder` (#4752) Use aggregated types for `RuntimeFreezeReason` and better examples of `MaxFreezes` (#4615) Update the pallet guide in `sdk-docs` (#4735) Hide `tuplex` dependency and re-export by macro (#4774)
… `MaxFreezes` (paritytech#4615) This PR aligns the settings for `MaxFreezes`, `RuntimeFreezeReason`, and `FreezeIdentifier`. #### Future work and improvements paritytech#2997 (remove `MaxFreezes` and `FreezeIdentifier`)
… `MaxFreezes` (paritytech#4615) This PR aligns the settings for `MaxFreezes`, `RuntimeFreezeReason`, and `FreezeIdentifier`. #### Future work and improvements paritytech#2997 (remove `MaxFreezes` and `FreezeIdentifier`)
This PR aligns the settings for
MaxFreezes,RuntimeFreezeReason, andFreezeIdentifier.Future work and improvements
#2997 (remove
MaxFreezesandFreezeIdentifier)