rpc: upgrade jsonrpsee v0.23 #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
T0-node
niklasad1
commented
Jun 12, 2024
| }; | ||
|
|
||
| let make_service = make_service_fn(move |addr: &AddrStream| { |
There was a problem hiding this comment.
hyper::service::make_service_fn is removed and we need to manage to socket ourselves.
Using to low-level API should easy to add support for ipv6 sockets but I'll fix it another PR.
niklasad1
commented
Jun 12, 2024
| @@ -124,7 +124,7 @@ pub struct LightClientRpcWorker { | |||
| } | |||
|
|
|||
| fn handle_notification( | |||
| maybe_header: Option<Result<RelayHeader, Error>>, | |||
| maybe_header: Option<Result<RelayHeader, serde_json::Error>>, | |||
There was a problem hiding this comment.
//cc @skunert
This is slightly modified and only decoding can cause this error now.
Since this API was confusing before i.e, the subscription could be closed because it lagged (i.e, couldn't keep with server) or just closed.
We have added another API https://docs.rs/jsonrpsee-core/0.23.1/jsonrpsee_core/client/struct.Subscription.html#method.close_reason but not sure whether you care here....
niklasad1
removed
the
A0-needs_burnin
bkchr
approved these changes
Jun 21, 2024
substrate/client/rpc-spec-v2/src/transaction/transaction_broadcast.rs
Outdated
Show resolved
Hide resolved
substrate/client/rpc-spec-v2/src/transaction/transaction_broadcast.rs
Outdated
Show resolved
Hide resolved
…cast.rs Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
…cast.rs Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
jsdw
approved these changes
Jun 24, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
acatangiu
approved these changes
Jun 26, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
This is PR updates jsonrpsee v0.23 which mainly changes: - Add `Extensions` which we now is using to get the connection id (used by the rpc spec v2 impl) - Update hyper to v1.0, http v1.0, soketto and related crates (hyper::service::make_service_fn is removed) - The subscription API for the client is modified to know why a subscription was closed. Full changelog here: https://github.com/paritytech/jsonrpsee/releases/tag/v0.23.0 --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This was referenced Aug 16, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR updates jsonrpsee v0.23 which mainly changes:
Extensionswhich we now is using to get the connection id (used by the rpc spec v2 impl)Full changelog here: https://github.com/paritytech/jsonrpsee/releases/tag/v0.23.0