[4 / 5] Make approval-voting runnable on a worker thread #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
changed the title
6 tasks
alexggh
changed the title
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-1-5
branch
from
381e0b9
to
88e15da
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
31767a9
to
7add070
Compare
alexggh
changed the title
alexggh
changed the base branch from
alexaggh/approval-voting-parallel-1-5
to
master
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
7add070
to
78708d7
Compare
alexggh
changed the base branch from
master
to
alexaggh/approval-voting-parallel-3-5
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-3-5
branch
from
88e15da
to
7c968e1
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
7add070
to
3a0ba90
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-3-5
branch
from
7c968e1
to
5fe747c
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
3a0ba90
to
78bb23d
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-3-5
branch
from
5fe747c
to
e4f883e
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
3 times, most recently
from
25f1f0a
to
d13e1c8
Compare
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-3-5
branch
from
e4f883e
to
14727c5
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
d13e1c8
to
1942139
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-1-5' into alexaggh/approval-voting-parallel-3-5
- rename check_and_import in import. - refactor un-needed variable. Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-3-5' into alexaggh/approval-voting-parallel-2-5
alexggh
added
T0-node
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…oting-parallel-3-5
…l-3-5' into alexaggh/approval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-3-5' into alexaggh/approval-voting-parallel-2-5
…oting-parallel-3-5
…l-3-5' into alexaggh/approval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…oting-parallel-3-5
…proval-voting-parallel-2-5
alindima
approved these changes
Aug 27, 2024
…oting-parallel-3-5
…ting Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…proval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Base automatically changed from
alexaggh/approval-voting-parallel-3-5
to
master
September 2, 2024 09:33
…oting-parallel-2-5
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading #4849 (comment),
Description
This PR contain changes to make possible the run of single approval-voting instance on a worker thread, so that it can be instantiated by the approval-voting-parallel subsystem.
This does not contain any functional changes it just decouples the subsystem from the subsystem Context and introduces more specific trait dependencies for each function instead of all of them requiring a context.
This change can be merged independent of the followup PRs.