[xcm] runtime api for LocationToAccount conversions #4857

bkontur · 2024-06-21T12:42:03Z

Closes: #4298

This PR also merges xcm-fee-payment-runtime-api module to the xcm-runtime-api.

TODO

rename convert to convert_location and add new one convert_account (opposite direction)
add to the all testnet runtimes
check polkadot-js if supports that automatically or if needs to be added manually Add LocationToAccountApi::convert_location runtime API polkadot-js/api#5917
backport/patch for fellows and release (asap)

Open questions

should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

Usage

Input:

location: VersionedLocation

Output:

account_id bytes

acatangiu

Looks good!

should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

that sounds good hygiene to me, makes sense to have a structure like:

xcm-runtime-api
|    mod conversions
|    mod dry_run
|    mod fees

polkadot/xcm/xcm-runtime-api/tests/conversions.rs

polkadot/xcm/xcm-runtime-api/src/conversions.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs

prdoc/pr_4857.prdoc

polkadot/xcm/xcm-runtime-api/src/conversions.rs

…c/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de>

Co-authored-by: Bastian Köcher <git@kchr.de>

paritytech-cicd-pr · 2024-06-26T10:32:33Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6554913

franciscoaguirre

🚀

polkadot/xcm/xcm-runtime-api/Cargo.toml

polkadot/xcm/xcm-runtime-api/tests/conversions.rs

prdoc/pr_4857.prdoc

Closes: paritytech#4298 This PR also merges `xcm-fee-payment-runtime-api` module to the `xcm-runtime-api`. ## TODO - [x] rename `convert` to `convert_location` and add new one `convert_account` (opposite direction) - [x] add to the all testnet runtimes - [x] check polkadot-js if supports that automatically or if needs to be added manually polkadot-js/api#5917 - [ ] backport/patch for fellows and release (asap) ## Open questions - [x] should we merge `xcm-runtime-api` and `xcm-fee-payment-runtime-api` to the one module `xcm-runtime-api` ? ## Usage Input: - `location: VersionedLocation` Output: - account_id bytes ![image](https://github.com/paritytech/polkadot-sdk/assets/8159517/4607b15a-77d2-462b-806c-606107776c0d) --------- Co-authored-by: Bastian Köcher <git@kchr.de> # Conflicts: # Cargo.lock # Cargo.toml # cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml # cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs # cumulus/parachains/runtimes/collectives/collectives-westend/Cargo.toml # cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs # cumulus/parachains/runtimes/contracts/contracts-rococo/Cargo.toml # cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs # cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml # cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs # cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml # cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs # cumulus/parachains/runtimes/people/people-rococo/Cargo.toml # cumulus/parachains/runtimes/people/people-rococo/src/lib.rs # cumulus/parachains/runtimes/people/people-westend/Cargo.toml # cumulus/parachains/runtimes/people/people-westend/src/lib.rs # cumulus/parachains/runtimes/testing/penpal/Cargo.toml # cumulus/parachains/runtimes/testing/penpal/src/lib.rs # cumulus/polkadot-parachain/Cargo.toml # polkadot/node/service/Cargo.toml # polkadot/runtime/rococo/Cargo.toml # polkadot/runtime/westend/Cargo.toml # polkadot/xcm/pallet-xcm/Cargo.toml # polkadot/xcm/xcm-runtime-apis/Cargo.toml # umbrella/Cargo.toml # umbrella/src/lib.rs

Closes: paritytech#4298 This PR also merges `xcm-fee-payment-runtime-api` module to the `xcm-runtime-api`. ## TODO - [x] rename `convert` to `convert_location` and add new one `convert_account` (opposite direction) - [x] add to the all testnet runtimes - [x] check polkadot-js if supports that automatically or if needs to be added manually polkadot-js/api#5917 - [ ] backport/patch for fellows and release (asap) ## Open questions - [x] should we merge `xcm-runtime-api` and `xcm-fee-payment-runtime-api` to the one module `xcm-runtime-api` ? ## Usage Input: - `location: VersionedLocation` Output: - account_id bytes ![image](https://github.com/paritytech/polkadot-sdk/assets/8159517/4607b15a-77d2-462b-806c-606107776c0d) --------- Co-authored-by: Bastian Köcher <git@kchr.de>

…imes (#413) Relates to: paritytech/polkadot-sdk#4298 Relates to: paritytech/polkadot-sdk#4857   - [ ] Does not require a CHANGELOG entry --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Dónal Murray <donalm@seadanda.dev>

bkontur added 2 commits June 21, 2024 14:37

Initial implementation of LocationToAccountApi runtime API

374e427

Add it to the AssetHubWestend

87e231b

bkontur added the T6-XCM This PR/Issue is related to XCM. label Jun 21, 2024

BabakArtist approved these changes Jun 22, 2024

View reviewed changes

bkontur added 6 commits June 24, 2024 23:10

Nits

db24e91

Use xcm::VersionedLocation instead of xcm::latest::Location

5cdf57a

Added to the all testnets

36eedd5

Merge remote-tracking branch 'origin/master' into bko-xcm-runtime-api

c9684b3

Change to workspace deps

eb547b3

One more

098d1fb

bkontur mentioned this pull request Jun 25, 2024

Add LocationToAccountApi::convert_location runtime API polkadot-js/api#5917

Merged

bkontur added 3 commits June 25, 2024 10:21

taplo zepter

5eff80c

clippy imports

bd99b8d

prdoc

0a7b5de

bkontur mentioned this pull request Jun 25, 2024

Runtime API for LocationToAccountId Conversion #4298

Closed

bkontur added 2 commits June 25, 2024 10:58

Again import

208d24c

Fix umbrella

6d7b3fc

bkontur marked this pull request as ready for review June 25, 2024 09:16

bkontur requested a review from a team as a code owner June 25, 2024 09:16

bkontur added 2 commits June 25, 2024 11:44

Umbrella?

e4f5f0b

Merge branch 'master' into bko-xcm-runtime-api

de7147a

acatangiu approved these changes Jun 25, 2024

View reviewed changes

bkchr reviewed Jun 25, 2024

View reviewed changes

polkadot/xcm/xcm-runtime-api/tests/conversions.rs Outdated Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/src/conversions.rs Outdated Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/src/conversions.rs Outdated Show resolved Hide resolved

bkontur and others added 7 commits June 25, 2024 15:06

Update polkadot/xcm/xcm-runtime-api/tests/conversions.rs

e9da1da

Co-authored-by: Bastian Köcher <git@kchr.de>

Update polkadot/xcm/xcm-runtime-api/src/conversions.rs

fe41925

Co-authored-by: Bastian Köcher <git@kchr.de>

Merge branch 'master' into bko-xcm-runtime-api

b5d8faa

Simplify XCM runtime API

7b83b94

More cleaning

6f3a41c

Import

f695e7a

Merge xcm-fee-payment-runtime-api to xcm-runtime-api

ab63f0d

bkchr approved these changes Jun 26, 2024

View reviewed changes

cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs Outdated Show resolved Hide resolved

prdoc/pr_4857.prdoc Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/src/conversions.rs Outdated Show resolved Hide resolved

bkontur and others added 3 commits June 26, 2024 12:17

Update cumulus/parachains/runtimes/collectives/collectives-westend/sr…

4511ecd

…c/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de>

Update prdoc/pr_4857.prdoc

18a9918

Co-authored-by: Bastian Köcher <git@kchr.de>

Update polkadot/xcm/xcm-runtime-api/src/conversions.rs

1089020

Co-authored-by: Bastian Köcher <git@kchr.de>

Reflect review comments

e39e6e7

bkontur enabled auto-merge June 26, 2024 12:33

franciscoaguirre approved these changes Jun 26, 2024

View reviewed changes

polkadot/xcm/xcm-runtime-api/Cargo.toml Outdated Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/tests/conversions.rs Outdated Show resolved Hide resolved

prdoc/pr_4857.prdoc Outdated Show resolved Hide resolved

bkontur disabled auto-merge June 26, 2024 12:45

bkontur added 2 commits June 26, 2024 15:06

More review comments

540433c

Merge remote-tracking branch 'origin/master' into bko-xcm-runtime-api

6457a41

bkontur enabled auto-merge June 26, 2024 13:08

bkontur added this pull request to the merge queue Jun 26, 2024

Merged via the queue into master with commit 7506956 Jun 26, 2024
153 of 159 checks passed

bkontur deleted the bko-xcm-runtime-api branch June 26, 2024 14:15

bkontur mentioned this pull request Jul 31, 2024

Add xcm_runtime_apis::conversions::LocationToAccountApi to all runtimes polkadot-fellows/runtimes#413

Merged

1 task

al3mart mentioned this pull request Aug 17, 2024

feat: Implement LocationToAccount runtime API r0gue-io/pop-node#210

Open

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Open

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

acatangiu assigned bkontur Sep 4, 2024

gonzamontiel mentioned this pull request Sep 4, 2024

Update moonbeam to polkadot stable2407 moonbeam-foundation/moonbeam#2932

Merged

Agusrodri mentioned this pull request Sep 27, 2024

Add XCM DryRun and LocationToAccount runtime APIs to all runtimes moonbeam-foundation/moonbeam#2980

Merged

TDemeco mentioned this pull request Oct 7, 2024

feat: ⏫ upgrade to Polkadot SDK v1.14.0 Moonsong-Labs/storage-hub#218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xcm] runtime api for LocationToAccount conversions #4857

[xcm] runtime api for LocationToAccount conversions #4857

bkontur commented Jun 21, 2024 •

edited

Loading

acatangiu left a comment

paritytech-cicd-pr commented Jun 26, 2024

franciscoaguirre left a comment

[xcm] runtime api for LocationToAccount conversions #4857

[xcm] runtime api for LocationToAccount conversions #4857

Conversation

bkontur commented Jun 21, 2024 • edited Loading

TODO

Open questions

Usage

acatangiu left a comment

Choose a reason for hiding this comment

paritytech-cicd-pr commented Jun 26, 2024

franciscoaguirre left a comment

Choose a reason for hiding this comment

bkontur commented Jun 21, 2024 •

edited

Loading