Fixes warnings in frame-support-procedural crate

[gupnik]

This PR fixes the unused warnings in frame-support-procedural crate, raised by the latest stable rust release.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6592216

[ggwpez]

Some description please to describe what this addresses, as i have no context on the change.

[bkchr]

Some description please to describe what this addresses, as i have no context on the change.

As the title says, it fixes some unused warnings coming with a newer stable.

[kianenigma]

Code looks good, but I want to further ask you to also semantically double check all the unused fields.

I worry that in the process where we made all of this unused, we have had some regression. Does all the code here, in terms of each macro's abilities, make sense to you?

For example, I see where being removed from construct_runtime. I remember this one, and it makes sense. But I cannot validate all the changes here.

Put differently, was everything that was previously unused, unused for a good reason?

[gupnik]

Thanks for the review.

Put differently, was everything that was previously unused, unused for a good reason?

Yes, all of these fields previously followed a standard API across all pallet components and it seems that the compiler was not smart enough to realise that some of those are not needed for specific components. With the latest stable, it was able to detect and raise it.

[kianenigma]

@paritytech-cicd-pr can we update the rust version in CI now? what is the process/owner for that?