Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridges] Prune messages from confirmation tx body, not from the on_idle #5006

Merged
merged 70 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from 68 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
bc0f814
Use compact proofs for messages delivery (#2155)
serban300 May 30, 2023
18b5b22
Moved FromBridgedChainMessagesDeliveryProof to bp-messages (#2169)
svyatonik Jun 1, 2023
379a600
Moved FromBridgedChainMessagesProof to bp-messages (#2170)
svyatonik Jun 1, 2023
7b5b01c
Separate folder for messages in relay lib (#2173)
svyatonik Jun 2, 2023
0278a54
Messages pallet benchmarks - cosmetics (#2175)
serban300 Jun 2, 2023
9197d85
Improve receive_messages_proof benchmarks accuracy (#2176)
serban300 Jun 5, 2023
7c46371
Moving messages code to pallet (#2180)
svyatonik Jun 5, 2023
acb15cc
use BridgedChain::Account instead of InbundRelayer (#2193)
svyatonik Jun 7, 2023
91d6f6b
Use compact proofs for parachains (#2194)
serban300 Jun 7, 2023
11cd08c
prune messages from confirmation tx, not from the on_idle (#2211)
svyatonik Jun 16, 2023
e5acef8
Fix maximal message dispatch weight (#2219)
svyatonik Jun 19, 2023
5303b2c
Box messages proof argument in receive_messages_proof call (#2222)
svyatonik Jun 20, 2023
6019c51
bump Substrate, Polkadot and Cumulus (#2223)
svyatonik Jun 21, 2023
4cbee73
Add test method for growing storage proof size (#2224)
serban300 Jun 21, 2023
1265806
fix some nightly errors (#2225)
svyatonik Jun 22, 2023
8a1d006
Renamings (#2226)
serban300 Jun 22, 2023
ccf2919
Fix clippy (#2240)
svyatonik Jul 4, 2023
37225c0
Some code grooming (#2276)
svyatonik Jul 17, 2023
f06c39f
Set `test-helpers` for `bp-runtime`
bkontur Jun 13, 2024
e2e7be3
Adjusted BH runtimes to the latest vogue
bkontur Jun 13, 2024
0325bdc
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jun 20, 2024
948e4ab
Removed unused `OtherBridgedChain` and `TargetClientBase`
bkontur Jun 26, 2024
b1b6ccf
zepter+taplo
bkontur Jun 26, 2024
096aca1
Revert wrong value + feature propagation
bkontur Jun 26, 2024
7e6b6b2
Getter for raw proof and fix features
bkontur Jun 27, 2024
c8a40ef
Added tests for macro compatibility with `pallet_bridge_messages` + fix
bkontur Jun 27, 2024
cdd1280
Updated new `substrate-relay` version `v2.0.0-rc1-compact-proof-ro-we…
bkontur Jun 27, 2024
bcf8050
Merge remote-tracking branch 'upstream/master' into bko-bridges-v2-co…
serban300 Jul 1, 2024
ded4e86
Revert compact-proofs-related changes (runtimes)
bkontur Jul 3, 2024
4c94e43
Remove compact proofs so they could be restored in different branch
bkontur Jul 3, 2024
94e977d
Make bridges relayer storage-proof-type agnostic
bkontur Jul 3, 2024
19f4011
Make bridges relayer storage-proof-type agnostic part 2
bkontur Jul 3, 2024
a367b49
Revert: `prune messages from confirmation tx, not from the on_idle (#…
bkontur Jul 3, 2024
6dbbb48
Fixes
bkontur Jul 3, 2024
3a149d9
nits
bkontur Jul 3, 2024
e4a1c5b
CI fixes
bkontur Jul 3, 2024
abd140f
more nits
bkontur Jul 3, 2024
685bcb4
fmt
bkontur Jul 3, 2024
cd6b1c7
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
Jul 3, 2024
2a3d5cc
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
39a5340
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
dcb550f
".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=br…
Jul 3, 2024
45155b3
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
43dcfc0
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
27dfe41
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
25ed0da
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
387e624
".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=br…
Jul 3, 2024
e2635b5
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
612cf2d
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
6047fa9
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
32d7455
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 3, 2024
233fb44
make check-crates job happy + prdoc nits
bkontur Jul 3, 2024
0f1c5ff
Adjust fees and prdoc
bkontur Jul 3, 2024
24b3a12
Merge remote-tracking branch 'origin/master' into bko-bridges-v2-back…
bkontur Jul 3, 2024
cf42701
macro nit + prdoc
bkontur Jul 4, 2024
5e4c70d
Merge remote-tracking branch 'origin/master' into bko-bridges-v2-back…
bkontur Jul 4, 2024
1ed7df7
Review comments
bkontur Jul 4, 2024
308ec4a
Nits
bkontur Jul 5, 2024
7c875be
[bridges] Prune messages from confirmation tx body, not from the on_i…
bkontur Jul 10, 2024
09a306f
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
Jul 11, 2024
1dc37bc
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 11, 2024
953e4bd
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 11, 2024
397dd61
Revert "[bridges] Prune messages from confirmation tx body, not from …
bkontur Jul 11, 2024
9b90f4b
prune messages from confirmation tx, not from the on_idle (#2211)
bkontur Jul 4, 2024
92515b8
Added `do_try_state_for_outbound_lanes` which checks unpruned messages
bkontur Jul 4, 2024
885ffbc
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 4, 2024
63d1074
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
Jul 4, 2024
59003a5
Aviod iteration all the time to the beginning
bkontur Jul 5, 2024
7be729a
Merge remote-tracking branch 'origin/master' into bko-bridges-v2-back…
bkontur Jul 12, 2024
7ec9b12
Merge remote-tracking branch 'origin/master' into bko-bridges-v2-back…
bkontur Jul 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 13 additions & 11 deletions bridges/bin/runtime-common/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,12 @@ workspace = true

[dependencies]
codec = { features = ["derive"], workspace = true }
hash-db = { workspace = true }
log = { workspace = true }
scale-info = { features = ["derive"], workspace = true }
static_assertions = { optional = true, workspace = true, default-features = true }
tuplex = { workspace = true }

# Bridge dependencies

bp-header-chain = { workspace = true }
bp-messages = { workspace = true }
bp-parachains = { workspace = true }
Expand All @@ -34,25 +32,23 @@ pallet-bridge-parachains = { workspace = true }
pallet-bridge-relayers = { workspace = true }

# Substrate dependencies

frame-support = { workspace = true }
frame-system = { workspace = true }
pallet-transaction-payment = { workspace = true }
pallet-utility = { workspace = true }
sp-api = { workspace = true }
sp-core = { workspace = true }
sp-io = { workspace = true }
sp-runtime = { workspace = true }
sp-std = { workspace = true }
sp-trie = { workspace = true }
sp-trie = { optional = true, workspace = true }

# Polkadot dependencies
xcm = { workspace = true }
xcm-builder = { workspace = true }

[dev-dependencies]
bp-test-utils = { workspace = true, default-features = true }
pallet-balances = { workspace = true, default-features = true }
bp-test-utils = { workspace = true }
pallet-balances = { workspace = true }
pallet-bridge-messages = { features = ["std", "test-helpers"], workspace = true }

[features]
default = ["std"]
Expand All @@ -63,22 +59,21 @@ std = [
"bp-polkadot-core/std",
"bp-relayers/std",
"bp-runtime/std",
"bp-test-utils/std",
"bp-xcm-bridge-hub-router/std",
"bp-xcm-bridge-hub/std",
"codec/std",
"frame-support/std",
"frame-system/std",
"hash-db/std",
"log/std",
"pallet-balances/std",
"pallet-bridge-grandpa/std",
"pallet-bridge-messages/std",
"pallet-bridge-parachains/std",
"pallet-bridge-relayers/std",
"pallet-transaction-payment/std",
"pallet-utility/std",
"scale-info/std",
"sp-api/std",
"sp-core/std",
"sp-io/std",
"sp-runtime/std",
"sp-std/std",
Expand All @@ -88,15 +83,22 @@ std = [
"xcm/std",
]
runtime-benchmarks = [
"bp-runtime/test-helpers",
"frame-support/runtime-benchmarks",
"frame-system/runtime-benchmarks",
"pallet-balances/runtime-benchmarks",
"pallet-bridge-grandpa/runtime-benchmarks",
"pallet-bridge-messages/runtime-benchmarks",
"pallet-bridge-messages/test-helpers",
"pallet-bridge-parachains/runtime-benchmarks",
"pallet-bridge-relayers/runtime-benchmarks",
"pallet-utility/runtime-benchmarks",
"sp-runtime/runtime-benchmarks",
"sp-trie",
"xcm-builder/runtime-benchmarks",
]
integrity-test = ["static_assertions"]
test-helpers = [
"bp-runtime/test-helpers",
"sp-trie",
]
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ mod integrity_tests {
pub mod per_message {
use super::*;

use bp_messages::ChainWithMessages;
use pallet_bridge_messages::WeightInfoExt;

/// Ensures that the value of `PriorityBoostPerMessage` matches the value of
Expand All @@ -339,7 +340,7 @@ mod integrity_tests {
BalanceOf<Runtime>: Send + Sync + FixedPointOperand,
{
let maximal_messages_in_delivery_transaction =
Runtime::MaxUnconfirmedMessagesAtInboundLane::get();
Runtime::BridgedChain::MAX_UNCONFIRMED_MESSAGES_IN_CONFIRMATION_TX;
super::ensure_priority_boost_is_sane::<PriorityBoostPerMessage, BalanceOf<Runtime>>(
"PriorityBoostPerMessage",
maximal_messages_in_delivery_transaction,
Expand Down
Loading
Loading