Refactor conviction voting to have field names in events #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidk-pt
added
I4-refactor
davidk-pt
force-pushed
the
davidk/refactor-conviction-voting-event-fields
branch
from
78c2e2f to
dd74d26
Compare
seadanda
approved these changes
Aug 8, 2024
muharem
reviewed
Aug 8, 2024
| /// An account has delegated their vote to another account. | ||
| Delegated { who: T::AccountId, target: T::AccountId }, | ||
| /// An account has cancelled a previous delegation operation. | ||
| Undelegated { who: T::AccountId }, |
There was a problem hiding this comment.
This change might break things for the clients. It's used in the governance. Not sure what we gain here.
I've seen the issue this PR trying to address. This is my personal opinion. I would not change it for existing events, specifically for the functionality that widely adopted. But for new events I would definitely use named fields.
There was a problem hiding this comment.
Thanks for the ping. The benefit it brings is negligible compared to the amount of UIs this is potentially going to break, it's indeed not worth it IMHO.
|
Closing not to break existing clients |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use Rust named event fields paritytech/substrate#9903
@paritytech/frame-coders @seadanda