Try State Hook for Recovery #5290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggwpez @kianenigma could you please review? |
62 tasks
ggwpez
requested changes
Aug 10, 2024
| fn try_state_friends() -> Result<(), sp_runtime::TryRuntimeError> { | ||
| Recoverable::<T>::iter().try_for_each(|(_, recovery_config)| -> DispatchResult { | ||
| ensure!( | ||
| recovery_config.friends.len() as u32 <= T::MaxFriends::get(), |
There was a problem hiding this comment.
friends is a bounded vec, which are guaranteed on a type level to never exceed their allowed length:
So i dont see how this is useful.
There was a problem hiding this comment.
@ggwpez Any suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #239
Polkadot address: 1e6LtEgMixb2vtQsEmCT8JW2Zpp3QynSxq8kcX9X54MxGTP