[Backport] Bump serde_json from 1.0.120 to 1.0.121 in the known_good_semver group (#5169) #5367

EgorPopelyaev · 2024-08-14T15:54:12Z

Bumps the known_good_semver group with 1 update:
serde_json.

Updates serde_json from 1.0.120 to 1.0.121

Release notes

v1.0.121

Optimize position search in error path (#1160, thanks @purplesyringa)

Commits

eca2658 Release 1.0.121
b0d678c Merge pull request #1160 from iex-rs/efficient-position
b1edc7d Optimize position search in error path
40dd7f5 Merge pull request #1159 from iex-rs/fix-recursion
6a306e6 Move call to tri! out of check_recursion!
3f1c6de Ignore byte_char_slices clippy lint in test
3fd6f5f Merge pull request #1153 from dpathakj/master
fcb5e83 Correct documentation URL for Value's Index impl.
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

…semver group (#5169) Bumps the known_good_semver group with 1 update: [serde_json](https://github.com/serde-rs/json). Updates `serde_json` from 1.0.120 to 1.0.121 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.121</h2> <ul> <li>Optimize position search in error path (<a href="https://redirect.github.com/serde-rs/json/issues/1160">#1160</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/eca2658a22cb39952783cb6914eb18242659f66a"><code>eca2658</code></a> Release 1.0.121</li> <li><a href="https://github.com/serde-rs/json/commit/b0d678cfb473386830d559b6ab255d9e21ba39c5"><code>b0d678c</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1160">#1160</a> from iex-rs/efficient-position</li> <li><a href="https://github.com/serde-rs/json/commit/b1edc7d13f72880fd0ac569403a409e5f7961d5f"><code>b1edc7d</code></a> Optimize position search in error path</li> <li><a href="https://github.com/serde-rs/json/commit/40dd7f5e862436f02471fe076f3486c55e472bc2"><code>40dd7f5</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1159">#1159</a> from iex-rs/fix-recursion</li> <li><a href="https://github.com/serde-rs/json/commit/6a306e6ee9f47f3b37088217ffe3ebe9bbb54e5a"><code>6a306e6</code></a> Move call to tri! out of check_recursion!</li> <li><a href="https://github.com/serde-rs/json/commit/3f1c6de4af28b1f6c5100da323f2bffaf7c2083f"><code>3f1c6de</code></a> Ignore byte_char_slices clippy lint in test</li> <li><a href="https://github.com/serde-rs/json/commit/3fd6f5f49dc1c732d9b1d7dfece4f02c0d440d39"><code>3fd6f5f</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1153">#1153</a> from dpathakj/master</li> <li><a href="https://github.com/serde-rs/json/commit/fcb5e83e44abe0f9c27c755a240a6ad56312c090"><code>fcb5e83</code></a> Correct documentation URL for Value's Index impl.</li> <li>See full diff in <a href="https://github.com/serde-rs/json/compare/v1.0.120...v1.0.121">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=serde_json&package-manager=cargo&previous-version=1.0.120&new-version=1.0.121)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>

github-actions · 2024-08-14T15:55:31Z

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
Should be a legit fix for some bug, not adding tons of new features.
Must either be already audited or trivial (not sure audit).

Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

EgorPopelyaev · 2024-08-14T16:13:32Z

@Morganamilo @ggwpez I guess this one will need a prdoc even though it was R0 initially, due to the failing semver check

ggwpez · 2024-08-14T16:21:17Z

I guess this one will need a prdoc even though it was R0 initially, due to the failing semver check

Only a no-OP prdoc basically. This should help: #5358

bkchr · 2024-08-14T19:22:36Z

Only a no-OP prdoc basically.

Actually a patch release of cumulus-timestamp 🙈

EgorPopelyaev · 2024-08-15T07:10:39Z

@bkchr Basti, what is the right audience for this change?

github-actions · 2024-08-15T07:22:45Z

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
Should be a legit fix for some bug, not adding tons of new features.
Must either be already audited or trivial (not sure audit).

Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

EgorPopelyaev · 2024-08-15T07:32:05Z

#5358

Ah, I guess we need to backport #5331 to the stable branch otherwise the action is failing. I'll add prdoc file manually this time

bkchr · 2024-08-15T07:32:36Z

Use node dev. Push the prdoc and I will check it

EgorPopelyaev · 2024-08-15T07:43:04Z

@bkchr Prdoc is up

prdoc/pr_5367.prdoc

bkchr · 2024-08-15T08:58:36Z

@EgorPopelyaev we are good to go

EgorPopelyaev · 2024-08-15T08:58:57Z

Thank you!

…semver group (paritytech#5169) (paritytech#5367) Bumps the known_good_semver group with 1 update: [serde_json](https://github.com/serde-rs/json). Updates `serde_json` from 1.0.120 to 1.0.121 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.121</h2> <ul> <li>Optimize position search in error path (<a href="https://redirect.github.com/serde-rs/json/issues/1160">#1160</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/eca2658a22cb39952783cb6914eb18242659f66a"><code>eca2658</code></a> Release 1.0.121</li> <li><a href="https://github.com/serde-rs/json/commit/b0d678cfb473386830d559b6ab255d9e21ba39c5"><code>b0d678c</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1160">#1160</a> from iex-rs/efficient-position</li> <li><a href="https://github.com/serde-rs/json/commit/b1edc7d13f72880fd0ac569403a409e5f7961d5f"><code>b1edc7d</code></a> Optimize position search in error path</li> <li><a href="https://github.com/serde-rs/json/commit/40dd7f5e862436f02471fe076f3486c55e472bc2"><code>40dd7f5</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1159">#1159</a> from iex-rs/fix-recursion</li> <li><a href="https://github.com/serde-rs/json/commit/6a306e6ee9f47f3b37088217ffe3ebe9bbb54e5a"><code>6a306e6</code></a> Move call to tri! out of check_recursion!</li> <li><a href="https://github.com/serde-rs/json/commit/3f1c6de4af28b1f6c5100da323f2bffaf7c2083f"><code>3f1c6de</code></a> Ignore byte_char_slices clippy lint in test</li> <li><a href="https://github.com/serde-rs/json/commit/3fd6f5f49dc1c732d9b1d7dfece4f02c0d440d39"><code>3fd6f5f</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1153">#1153</a> from dpathakj/master</li> <li><a href="https://github.com/serde-rs/json/commit/fcb5e83e44abe0f9c27c755a240a6ad56312c090"><code>fcb5e83</code></a> Correct documentation URL for Value's Index impl.</li> <li>See full diff in <a href="https://github.com/serde-rs/json/compare/v1.0.120...v1.0.121">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=serde_json&package-manager=cargo&previous-version=1.0.120&new-version=1.0.121)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>

EgorPopelyaev added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes A3-backport Pull request is already reviewed well in another branch. labels Aug 14, 2024

EgorPopelyaev requested review from bkchr, ggwpez and Morganamilo August 14, 2024 15:54

ggwpez approved these changes Aug 14, 2024

View reviewed changes

bkchr approved these changes Aug 14, 2024

View reviewed changes

add prdoc

5c54f27

bkchr reviewed Aug 15, 2024

View reviewed changes

prdoc/pr_5367.prdoc Outdated Show resolved Hide resolved

Update prdoc/pr_5367.prdoc

8a54cff

EgorPopelyaev merged commit 96b3051 into stable2407 Aug 15, 2024
38 of 90 checks passed

EgorPopelyaev deleted the ep-backport-5169 branch August 15, 2024 08:59

TDemeco mentioned this pull request Oct 7, 2024

feat: ⏫ upgrade to Polkadot SDK stable2407 Moonsong-Labs/storage-hub#222

Merged

Aideepakchaudhary mentioned this pull request Oct 23, 2024

Feat: Polkadot v1.14 to stable2407 upgrade Cerebellum-Network/blockchain-node#455

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Bump serde_json from 1.0.120 to 1.0.121 in the known_good_semver group (#5169) #5367

[Backport] Bump serde_json from 1.0.120 to 1.0.121 in the known_good_semver group (#5169) #5367

EgorPopelyaev commented Aug 14, 2024

github-actions bot commented Aug 14, 2024

EgorPopelyaev commented Aug 14, 2024

ggwpez commented Aug 14, 2024

bkchr commented Aug 14, 2024

EgorPopelyaev commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 •

edited

Loading

EgorPopelyaev commented Aug 15, 2024

bkchr commented Aug 15, 2024

EgorPopelyaev commented Aug 15, 2024 •

edited

Loading

bkchr commented Aug 15, 2024

EgorPopelyaev commented Aug 15, 2024

[Backport] Bump serde_json from 1.0.120 to 1.0.121 in the known_good_semver group (#5169) #5367

[Backport] Bump serde_json from 1.0.120 to 1.0.121 in the known_good_semver group (#5169) #5367

Conversation

EgorPopelyaev commented Aug 14, 2024

v1.0.121

github-actions bot commented Aug 14, 2024

EgorPopelyaev commented Aug 14, 2024

ggwpez commented Aug 14, 2024

bkchr commented Aug 14, 2024

EgorPopelyaev commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 • edited Loading

EgorPopelyaev commented Aug 15, 2024

bkchr commented Aug 15, 2024

EgorPopelyaev commented Aug 15, 2024 • edited Loading

bkchr commented Aug 15, 2024

EgorPopelyaev commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 •

edited

Loading

EgorPopelyaev commented Aug 15, 2024 •

edited

Loading