Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame-omni-bencher maintenance #5466

Merged
merged 10 commits into from
Aug 27, 2024
Merged

frame-omni-bencher maintenance #5466

merged 10 commits into from
Aug 27, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 26, 2024

Changes:

  • Set default level to Info again. Seems like a dependency update set it to something higher.
  • Fix docs to not use --locked since we rely on dependency bumps via cargo.
  • Add README with rust docs.
  • Fix bug where the node ignored --heap-pages argument.

You can test the --heap-pages bug by running this command on master and then on this branch. Note that it should fail because of the very low heap pages arg:
cargo run --release --bin polkadot --features=runtime-benchmarks -- benchmark pallet --chain=dev --steps=10 --repeat=30 --wasm-execution=compiled --heap-pages=8 --pallet=frame-system --extrinsic="*"

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Aug 26, 2024
@ggwpez ggwpez marked this pull request as draft August 26, 2024 14:45
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review August 26, 2024 15:05
- audience: Runtime Dev
description: "Changes:\r\n- Set default level to `Info` again. Seems like a dependency\
\ update set it to something higher.\r\n- Fix docs to not use `--locked` since\
\ we rely on dependency bumps via cargo.\r\n- Add README with rust docs."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time trying out the bot. Looks a bit mangled 😅

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7132286

prdoc/pr_5466.prdoc Outdated Show resolved Hide resolved
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the A4-needs-backport Pull request must be backported to all maintained releases. label Aug 26, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added this pull request to the merge queue Aug 27, 2024
Merged via the queue into master with commit 7e7c334 Aug 27, 2024
188 of 189 checks passed
@ggwpez ggwpez deleted the oty-omni-bencher branch August 27, 2024 10:35
ordian added a commit that referenced this pull request Aug 29, 2024
* master: (39 commits)
  short-term fix for para inherent weight overestimation (#5082)
  CI: Add backporting bot (#4795)
  Fix benchmark failures when using `insecure_zero_ed` flag (#5354)
  Command bot GHA v2 - /cmd <cmd> (#5457)
  Remove pallet::getter usage from treasury (#4962)
  Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
  Bump rustversion from 1.0.14 to 1.0.17 (#5405)
  Bridge zombienet tests: remove old command (#5434)
  polkadot-parachain: Add omni-node variant with u64 block number (#5269)
  Refactor verbose test (#5506)
  Use umbrella crate for minimal template (#5155)
  IBP Coretime Polkadot bootnodes (#5499)
  rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
  Update approval-voting-regression-bench (#5504)
  change try-runtime rpc domains (#5443)
  polkadot-parachain-bin: Remove contracts parachain (#5471)
  Add feature to allow Aura collator to use full PoV size (#5393)
  Adding stkd bootnodes (#5470)
  Make `PendingConfigs` storage item public (#5467)
  frame-omni-bencher maintenance (#5466)
  ...
@ggwpez ggwpez added A4-needs-backport Pull request must be backported to all maintained releases. and removed A4-needs-backport Pull request must be backported to all maintained releases. labels Aug 29, 2024
Copy link

Backport failed for stable2407, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable2407
git worktree add -d .worktree/backport-5466-to-stable2407 origin/stable2407
cd .worktree/backport-5466-to-stable2407
git switch --create backport-5466-to-stable2407
git cherry-pick -x 7e7c33453eeb14f47c6c4d0f98cc982e485edc77

@ggwpez ggwpez added A4-needs-backport Pull request must be backported to all maintained releases. and removed A4-needs-backport Pull request must be backported to all maintained releases. labels Aug 29, 2024
Copy link

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5466-to-stable2407
git worktree add --checkout .worktree/backport-5466-to-stable2407 backport-5466-to-stable2407
cd .worktree/backport-5466-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 7e7c33453eeb14f47c6c4d0f98cc982e485edc77
git push --force-with-lease

ggwpez added a commit that referenced this pull request Aug 29, 2024
Changes:
- Set default level to `Info` again. Seems like a dependency update set
it to something higher.
- Fix docs to not use `--locked` since we rely on dependency bumps via
cargo.
- Add README with rust docs.
- Fix bug where the node ignored `--heap-pages` argument.

You can test the `--heap-pages` bug by running this command on master
and then on this branch. Note that it should fail because of the very
low heap pages arg:
`cargo run --release --bin polkadot --features=runtime-benchmarks --
benchmark pallet --chain=dev --steps=10 --repeat=30
--wasm-execution=compiled --heap-pages=8 --pallet=frame-system
--extrinsic="*"`

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 7e7c334)
bkchr pushed a commit that referenced this pull request Sep 10, 2024
Backport #5466 into `stable2407` (cc @ggwpez).

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez removed the A4-needs-backport Pull request must be backported to all maintained releases. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants