Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Always include UnpaidExecution, not just when revenue is nonzero #5510

Merged
merged 2 commits into from
Aug 28, 2024
Merged

[Backport] Always include UnpaidExecution, not just when revenue is nonzero #5510

merged 2 commits into from
Aug 28, 2024

Conversation

seadanda
Copy link
Contributor

Backport #5369 to stable2407, which was already backported to v1.14 in #5370

@seadanda
[Coretime] Always include UnpaidExecution, not just when revenue is >…
f570b0d 
… 0 (#5369)

The NotifyRevenue XCM from relay to coretime chain fails to pass the
barrier when revenue is 0.


https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L401
pushes notifyrevenue onto an [empty
vec](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L361)
when `revenue == 0`, so it never explicitly requests unpaid execution,
because that happens only in [the block where revenue is `>
0`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L387).

This will need to be backported to 1.14 when merged.
@seadanda seadanda added A3-backport Pull request is already reviewed well in another branch. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Aug 28, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@ggwpez ggwpez merged commit a38e8d5 into stable2407 Aug 28, 2024
135 of 162 checks passed
@ggwpez ggwpez deleted the donal-backport-5369-stable2407 branch August 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seadanda @ggwpez