-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more logs for AcceptanceCheckErr #5513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 29, 2024
@zjb0807 please add a prdoc. |
Review required! Latest push from author must always be reviewed |
bkchr
approved these changes
Aug 29, 2024
alexggh
approved these changes
Aug 30, 2024
auto-merge was automatically disabled
August 30, 2024 12:24
Head branch was pushed to by a user without write access
@zjb0807 please use merge commits in the future. |
sandreim
approved these changes
Aug 30, 2024
Merged
via the queue into
paritytech:master
with commit Aug 30, 2024
9cdf3d9
146 of 186 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message should be logged out when the check method returns an error.
Because specific information is lost when
UmpAcceptanceCheckErr
,ProcessedDownwardMessagesAcceptanceErr
,HrmpWatermarkAcceptanceErr
,OutboundHrmpAcceptanceErr
are converted toAcceptanceCheckErr
, a log is added to each check.Integration
Review Notes
Checklist
T
required)