Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs for AcceptanceCheckErr #5513

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Add more logs for AcceptanceCheckErr #5513

merged 2 commits into from
Aug 30, 2024

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Aug 29, 2024

Description

The error message should be logged out when the check method returns an error.

Because specific information is lost when UmpAcceptanceCheckErr, ProcessedDownwardMessagesAcceptanceErr, HrmpWatermarkAcceptanceErr, OutboundHrmpAcceptanceErr are converted to AcceptanceCheckErr, a log is added to each check.

Integration

Review Notes

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: ask maintainers to put the right label on your PR.
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@zjb0807 zjb0807 changed the title add more logs Add more logs for AcceptanceCheckErr Aug 29, 2024
@bkchr
Copy link
Member

bkchr commented Aug 29, 2024

@zjb0807 please add a prdoc.

@bkchr bkchr added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 29, 2024
@github-actions github-actions bot requested a review from bkchr August 29, 2024 09:33
Copy link

Review required! Latest push from author must always be reviewed

@bkchr bkchr requested a review from alexggh August 29, 2024 21:38
@bkchr bkchr enabled auto-merge August 29, 2024 21:38
auto-merge was automatically disabled August 30, 2024 12:24

Head branch was pushed to by a user without write access

@github-actions github-actions bot requested review from alexggh and bkchr August 30, 2024 12:24
@bkchr
Copy link
Member

bkchr commented Aug 30, 2024

@zjb0807 please use merge commits in the future.

@bkchr bkchr enabled auto-merge August 30, 2024 12:25
@bkchr bkchr added this pull request to the merge queue Aug 30, 2024
Merged via the queue into paritytech:master with commit 9cdf3d9 Aug 30, 2024
146 of 186 checks passed
@zjb0807 zjb0807 deleted the logs branch August 31, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants