umbrella create Tweaks #5516
umbrella create Tweaks #5516
Conversation
| "frame-benchmarking", | ||
| "frame-benchmarking-pallet-pov", | ||
| "frame-election-provider-solution-type", | ||
| "frame-election-provider-support", | ||
| "frame-executive", | ||
| "frame-metadata-hash-extension", | ||
| "frame-support", | ||
| "frame-support-procedural", | ||
| "frame-support-procedural-tools-derive", | ||
| "frame-system", | ||
| "frame-system-benchmarking", | ||
| "frame-system-rpc-runtime-api", | ||
| "frame-try-runtime", |
There was a problem hiding this comment.
@kianenigma @ggwpe a few tweaks: these crates don't need to be in the runtime features as well, as they are already included in polkadot-sdk-frame, they were also causing some annyoning warning when compiling
There was a problem hiding this comment.
features names are not global. If the frame-benchmarking feature is not activated in this Cargo.toml then even if polkadot-sdk-frame has a feature with the same name, then the feature won't be activated. This means when compiled with feature runtime, the umbrella will not reexport frame-benchmarking. frame-benchmarking will only be available from polkadot-sdk-frame. Is it what we want?
There was a problem hiding this comment.
frame-benchmarking. frame-benchmarking will only be available from polkadot-sdk-frame. Is it what we want?
Yeah I think that is fine to access all frames thing through polkadot-sdk-frame
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| "frame-support/try-runtime", | ||
| "frame-system/try-runtime", | ||
| "sp-runtime/try-runtime" | ||
| ] |
There was a problem hiding this comment.
why do we need this, for tests?
There was a problem hiding this comment.
that's added by zepter, automatically, I explicity added try-runtime feature in the cargo as it complains in some situation with
warning: unexpected `cfg` condition value: `try-runtime`
--> substrate/frame/support/procedural/src/lib.rs:323:31
There was a problem hiding this comment.
in the past it has been avoided see this comment: #5099 (comment)
But in this exact case, it doesn't harm. But if it then get used for different usecase, then I don't know.
Note that we could fix it like this: https://github.com/paritytech/polkadot-sdk/compare/pg/umbrella-tweak...gui1117:gui-fix-try-runtime-usage-in-frame-support?expand=1
There was a problem hiding this comment.
Note that we could fix it like this
Yea that looks like the proper fix 🙏
| @@ -87,7 +87,8 @@ def main(path, version): | |||
| std_crates.sort(key=lambda x: x[0].name) | |||
| nostd_crates.sort(key=lambda x: x[0].name) | |||
|
|
|||
| runtime_crates = [crate for crate in nostd_crates if 'frame' in crate[0].name or crate[0].name.startswith('sp-')] | |||
| frame_crates_names = [ "polkadot-sdk-frame", "frame-support", "frame-system", ] | |||
| runtime_crates = [crate for crate in nostd_crates if crate[0].name.startswith('sp-') or crate[0].name in frame_crates_names] | |||
There was a problem hiding this comment.
We should then probably also have a runtime-full feature or something like that.
No description provided.